From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"William Zhang" <william.zhang@broadcom.com>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Fernández Rojas" <noltari@gmail.com>,
"Sven Schwermer" <sven.schwermer@disruptive-technologies.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v9 3/5] net: phy: add support for PHY LEDs polarity modes
Date: Tue, 9 Jan 2024 02:17:28 +0100 [thread overview]
Message-ID: <b7bccef0-570a-4ed9-b349-6d7d0fcc2e2a@lunn.ch> (raw)
In-Reply-To: <20240105142719.11042-4-ansuelsmth@gmail.com>
On Fri, Jan 05, 2024 at 03:27:15PM +0100, Christian Marangi wrote:
> Add support for PHY LEDs polarity modes. Some PHY require LED to be set
> to active low to be turned ON. Adds support for this by declaring
> active-low property in DT.
>
> PHY driver needs to declare .led_polarity_set() to configure LED
> polarity modes. Function will pass the index with the LED index and a
> bitmap with all the required modes to set.
>
> Current supported modes are:
> - active-low with the flag PHY_LED_ACTIVE_LOW. LED is set to active-low
> to turn it ON.
> - inactive-high-impedance with the flag PHY_LED_INACTIVE_HIGH_IMPEDANCE.
> LED is set to high impedance to turn it OFF.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-01-09 1:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 14:27 [net-next PATCH v9 0/5] net: phy: generic polarity + LED support for qca808x Christian Marangi
2024-01-05 14:27 ` [net-next PATCH v9 1/5] dt-bindings: net: phy: Make LED active-low property common Christian Marangi
2024-01-09 0:38 ` Andrew Lunn
2024-01-11 11:03 ` Lee Jones
2024-01-13 1:29 ` Rob Herring
2024-01-05 14:27 ` [net-next PATCH v9 2/5] dt-bindings: net: phy: Document LED inactive high impedance mode Christian Marangi
2024-01-09 0:39 ` Andrew Lunn
2024-01-11 11:02 ` Lee Jones
2024-01-13 1:29 ` Rob Herring
2024-01-05 14:27 ` [net-next PATCH v9 3/5] net: phy: add support for PHY LEDs polarity modes Christian Marangi
2024-01-09 1:17 ` Andrew Lunn [this message]
2024-01-05 14:27 ` [net-next PATCH v9 4/5] dt-bindings: net: Document QCA808x PHYs Christian Marangi
2024-01-05 14:27 ` [net-next PATCH v9 5/5] net: phy: at803x: add LED support for qca808x Christian Marangi
2024-01-09 1:20 ` Andrew Lunn
2024-01-09 3:14 ` [net-next PATCH v9 0/5] net: phy: generic polarity + " Jakub Kicinski
2024-01-09 13:55 ` Andrew Lunn
2024-01-22 23:14 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7bccef0-570a-4ed9-b349-6d7d0fcc2e2a@lunn.ch \
--to=andrew@lunn.ch \
--cc=anand.gore@broadcom.com \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kursad.oney@broadcom.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=sven.schwermer@disruptive-technologies.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®