mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vignesh Raman <vignesh.raman@collabora.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com,
	helen.fornazier@gmail.com, airlied@gmail.com,
	simona.vetter@ffwll.ch, robdclark@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, guilherme.gallo@collabora.com,
	sergi.blanch.torne@collabora.com, valentine.burley@collabora.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drm/ci: remove CI_PRE_CLONE_SCRIPT
Date: Fri, 28 Feb 2025 08:48:49 +0530	[thread overview]
Message-ID: <b7c1ca07-e59e-4819-b81a-d4c53c11f830@collabora.com> (raw)
In-Reply-To: <ukzyfymij2yilyy7ofyi3hj4urlrxxbx5rre3f7qg4zgkc65u5@vbutj63ucctc>

Hi Dmitry,

On 27/02/25 11:21, Dmitry Baryshkov wrote:
> On Thu, Feb 27, 2025 at 10:06:24AM +0530, Vignesh Raman wrote:
>> If we are not caching the git archive, do not
>> set CI_PRE_CLONE_SCRIPT. Setting it makes CI
>> try to download the cache first, and if it is
>> missing, it tries to clone the repo within a
>> time limit, which can cause build failures.
> 
> Please wrap the commit message according to the guidelines. 47 chars in
> a line is way too short.
> 
> BTW: this didn't help with the python-artifacts issue. It still times
> out.

The issue was with shallow cloning, and I have posted another patch.
https://lore.kernel.org/dri-devel/20250228031501.483475-1-vignesh.raman@collabora.com/T/#u

The commit message is wrapped according to the guidelines in this patch.

Thanks.

Regards,
Vignesh

> 
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>> ---
>>   drivers/gpu/drm/ci/gitlab-ci.yml | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
>> index f4e324e156db..0bc4ac344757 100644
>> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
>> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
>> @@ -13,12 +13,6 @@ variables:
>>     FDO_UPSTREAM_REPO: helen.fornazier/linux   # The repo where the git-archive daily runs
>>     MESA_TEMPLATES_COMMIT: &ci-templates-commit d5aa3941aa03c2f716595116354fb81eb8012acb
>>     DRM_CI_PROJECT_URL: https://gitlab.freedesktop.org/${DRM_CI_PROJECT_PATH}
>> -  CI_PRE_CLONE_SCRIPT: |-
>> -          set -o xtrace
>> -          curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${DRM_CI_PROJECT_URL}/-/raw/${DRM_CI_COMMIT_SHA}/.gitlab-ci/download-git-cache.sh -o download-git-cache.sh
>> -          bash download-git-cache.sh
>> -          rm download-git-cache.sh
>> -          set +o xtrace
>>     S3_JWT_FILE: /s3_jwt
>>     S3_JWT_FILE_SCRIPT: |-
>>         echo -n '${S3_JWT}' > '${S3_JWT_FILE}' &&
>> -- 
>> 2.47.2
>>
> 


      reply	other threads:[~2025-02-28  3:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27  4:36 Vignesh Raman
2025-02-27  5:51 ` Dmitry Baryshkov
2025-02-28  3:18   ` Vignesh Raman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7c1ca07-e59e-4819-b81a-d4c53c11f830@collabora.com \
    --to=vignesh.raman@collabora.com \
    --cc=airlied@gmail.com \
    --cc=daniels@collabora.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guilherme.gallo@collabora.com \
    --cc=helen.fornazier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sergi.blanch.torne@collabora.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=valentine.burley@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®