From: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: em28xx: return error on media_device_register() failure
Date: Thu, 11 Jan 2024 07:10:10 -0800 [thread overview]
Message-ID: <b7ca60c4-2392-448e-90e4-5078051d7af6@fintech.ru> (raw)
In-Reply-To: <20240111074905.67d61b00@coco.lan>
On 1/10/24 22:49, Mauro Carvalho Chehab wrote:
> Em Wed, 10 Jan 2024 09:39:58 -0800
> Nikita Zhandarovich <n.zhandarovich@fintech.ru> escreveu:
>
>> In an unlikely case of failure in media_device_register(), release
>> resources and return the erroneous value. Otherwise, possible issues
>> with registering the device will continue to be ignored.
>>
>> Found by Linux Verification Center (linuxtesting.org) with static
>> analysis tool SVACE.
>>
>> Fixes: 37ecc7b1278f ("[media] em28xx: add media controller support")
>> Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
>> ---
>> drivers/media/usb/em28xx/em28xx-cards.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
>> index 4d037c92af7c..dae731dfc569 100644
>> --- a/drivers/media/usb/em28xx/em28xx-cards.c
>> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
>> @@ -4095,6 +4095,8 @@ static int em28xx_usb_probe(struct usb_interface *intf,
>> */
>> #ifdef CONFIG_MEDIA_CONTROLLER
>> retval = media_device_register(dev->media_dev);
>> + if (retval)
>> + goto err_free;
>
> Not freeing resources here is intentional. See, the media controller
> API is optional on this driver. It will just provide a way to identify
> the device's topology, but the device is completely usable without
> it.
>
> Perhaps we need, instead, a patch documenting it, and preventing
> static analysis tools to point it as an issue.
>
> Thanks,
> Mauro
Thank you for your feedback, however I had a few questions...
While I understand what you mean about optional nature of media
controller registration in this case, a quick glance into other calls to
media_device_register() across the source code shows that usually
failure with registering is handled as a proper error regardless of
whether the device is still usable. But if you think that we can make an
exception here, I'll happily oblige.
Then if I am to continue on this path, would the following comment above
the call to media_device_register() suffice?
#ifdef CONFIG_MEDIA_CONTROLLER
+ /*
+ * No need to check the return value, the device will still be +
* usable without media controller API.
+ */
retval = media_device_register(dev->media_dev);
Thanks,
Nikita
next prev parent reply other threads:[~2024-01-11 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 17:39 Nikita Zhandarovich
2024-01-10 19:15 ` Christophe JAILLET
2024-01-11 6:49 ` Mauro Carvalho Chehab
2024-01-11 15:10 ` Nikita Zhandarovich [this message]
2024-01-11 17:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7ca60c4-2392-448e-90e4-5078051d7af6@fintech.ru \
--to=n.zhandarovich@fintech.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®