From: Sean Anderson <seanga2@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Nick Bowler <nbowler@draconx.ca>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Zheyu Ma <zheyuma97@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
Date: Tue, 27 Sep 2022 09:57:50 -0400 [thread overview]
Message-ID: <b7cc392b-448d-ad40-f915-4b4e4b8c232b@gmail.com> (raw)
In-Reply-To: <9412f706a4934d218019d74c5f4b74ae@AcuMS.aculab.com>
On 9/27/22 03:58, David Laight wrote:
> From: Sean Anderson
>> Sent: 24 September 2022 02:54
>>
>> With the power of variadic macros, double parentheses are unnecessary.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> Changes in v2:
>> - sumhme -> sunhme
>>
>> drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>> 1 file changed, 136 insertions(+), 136 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
>> index 7d6825c573a2..77a2a192f2ce 100644
>> --- a/drivers/net/ethernet/sun/sunhme.c
>> +++ b/drivers/net/ethernet/sun/sunhme.c
>> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>> #endif
>>
>> #ifdef HMEDEBUG
>> -#define HMD(x) printk x
>> +#define HMD printk
>
> That probably ought to be:
> #define HMD(...) printk(__VA_ARGS__)
>
> (and followed through all the other patches)
The final macro is
#define hme_debug(fmt, ...) pr_debug("%s: " fmt, __func__, ##__VA_ARGS__)
#define HMD hme_debug
so I think that satisfies your comment.
--Sean
next prev parent reply other threads:[~2022-09-27 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 1:53 [PATCH net-next v2 00/13] net: sunhme: Cleanups and logging improvements Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 01/13] sunhme: remove unused tx_dump_ring() Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 02/13] sunhme: Remove version Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 03/13] sunhme: forward the error code from pci_enable_device() Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 04/13] sunhme: Return an ERR_PTR from quattro_pci_find Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 05/13] sunhme: Regularize probe errors Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 06/13] sunhme: switch to devres Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...) Sean Anderson
2022-09-27 7:58 ` David Laight
2022-09-27 13:57 ` Sean Anderson [this message]
2022-09-24 1:53 ` [PATCH net-next v2 08/13] sunhme: Clean up debug infrastructure Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 09/13] sunhme: Convert printk(KERN_FOO ...) to pr_foo(...) Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 10/13] sunhme: Use (net)dev_foo wherever possible Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 11/13] sunhme: Combine continued messages Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 12/13] sunhme: Use vdbg for spam-y prints Sean Anderson
2022-09-24 1:53 ` [PATCH net-next v2 13/13] sunhme: Add myself as a maintainer Sean Anderson
2022-09-27 0:50 ` [PATCH net-next v2 00/13] net: sunhme: Cleanups and logging improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7cc392b-448d-ad40-f915-4b4e4b8c232b@gmail.com \
--to=seanga2@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eike-kernel@sf-tec.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@draconx.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®