From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDAE5384228 for ; Fri, 5 Jun 2026 15:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780674489; cv=none; b=BivDVE2KZ0CiA+OHfFi4+G+W6NHTN6gCFqS5mJzMyAt9opxtsw9+SClPi34K49jUR42cdm6fFWaAdZkrckj4tyfSlwRDeYRO8PdeM5wvZPXt3RCVVYDBfAr3vdkJaHdtDH68c9WEjLxScqDhNCE40vgVsRCTWvuC/O/shUivNx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780674489; c=relaxed/simple; bh=+Zytpm9FXTTuYrQ6mlBrz/G+YKHNBxOZR5sKcsiQPHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pMh7r6XHiJL1iwaSm4X1sg39YHJH0H7/L1IxKuRKSGoxnsg52yKEYT17A+uASRd++HhcmO1OO1pvJ1JNgeD7ulYr4Zp1PbLmkRhStFMdJSlZE4XU+/2f4f1FANl8+dOkTtI/UDNPNjw7BATFhAFM0mH7FE2qUA1Jr3CEEMVU02g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RreD1ojS; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RreD1ojS" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45eea68dd6fso1117716f8f.2 for ; Fri, 05 Jun 2026 08:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780674486; x=1781279286; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YIe9PJTXxBHQ0XX31cWOxKtFhK/4Vta8bzAs10DDqbM=; b=RreD1ojSSvFRxLANmDwpf73LEaNmskuGnORFmXWq/K39Nqhn4H5NLwHHhyg/NGgwCE 8kioymVffyFHJssUZVmaGG1B5gWHuvzdiOKfnk/wLXhib9QIxnnUAhVesvSGBbp32oiG jtMeDVlm91hQ8i0+wmoN5EtcqvDUcrmFHuMqEFP95HvHAY6g276aZPnIx/Kr47vICIss 7kp5QPj/EndCJHfR3xtqWJw+1Y3GpoBouOXFHzG+p9sdklzt2V/696G8kso71WeziGvg +Vl0DfqTzA/8Mc7msouSI0Cgf0xs9YvFXoxlK3IlsjVQueewCOL8vnPGg13FS6DNu+kT wzng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780674486; x=1781279286; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YIe9PJTXxBHQ0XX31cWOxKtFhK/4Vta8bzAs10DDqbM=; b=A2eIutYsP8g11EE2kO28qirqLBSdseh40R1V0PyIEml5nGUekM9rOspE9KyXeWJRX+ wizbHHa1ZdvA4yFi4fPMfVIAzFZ9TjfhFnTEh2GwLcL7WRr4fStUf08QPwKmt5d5Rnur JulUEfImvCgZYmpEwJa8FBbEHJ7FCMY7q28GoGvGIoD5kFhoOiNG0EVFmeYb9wkx7deE ARHlI5dfMQeMQfI1Nv6giCYcitsToZe3RBPb/P9+WclbYOpL6oM46N1jnh6wjCNQWV5d +SRrAVJhGoBQMNoVx007c2tZI2TbUXNGx4ZXsi789r+tFZQayFTNBgKFpFdbo8r0Htww rwmg== X-Forwarded-Encrypted: i=1; AFNElJ9yGMHFkdzwm9bPRgFs5sYGhDlUCt7+EvRvmfsh3Jug5zmB7whVSYN5q3X/wTieQn6Pb40xvAwGS2LSHiE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk5Ht1r4Mict8olRfuxFe58PTb7eHUMefQ05RKFEztYsmBDokc jVvfQSASsSr+WGKnG6iR57YW0G3W8eZNZHpSxADepIwjHHsx9+CqPovp X-Gm-Gg: Acq92OHZaJylIVSqxWa8mjpQFj6VKqSx/i3uB6aDuzDZy3AAqSaG4xb9RooS9DMcSdD IF69fp+pqtdrU2qi4qtc0GfFe+n3c10CjSHXZc/PkuyGX26L6jLtHpo1G/V9tbuNfpjbsIy3z/D rQMn9XJ6bap93HJlAqbOW7RVT2azwSgNz9JWPpkZ4gL+Rkw8/HFp4/+Yu6mt1U5b0UW5dz/xYBK dsRzEth0Usn9iW7gKnLipafm5TV6XI4D2h3c/ONh8CGYH628M8EiPYhmYtkL5PlcMHfN0ScMfR+ cXQ3/b/WrebNSu2nCAwsr3Nz7Urdpv0xxv84lEYAMVLFcNac00nNnm8aQhx4NHWowWodluDSHBk psGdqrbFhJQW6cmk8sIbaFR433eeWj1ElNVuIvlL/ZDI7Aw3PR7DPEPXrE/QYJ2KfHRbq4mLyPb nSb9VYcY0GiKHnZDoFuk+vZG8J1dSuhs34FihiafKA9/o9rxwMmnfDJfJ5rP7zcqhf6tb1bDXe7 v1OcoLrhKkwatQMYrjfrrKmVy+Q0IzluQDY6FEGeOqwVAM3UrcQmF2XbEjQiwya3WrODmHUKSSZ X-Received: by 2002:adf:ef88:0:b0:460:1e9d:31a5 with SMTP id ffacd0b85a97d-46030631ba3mr5236539f8f.35.1780674485919; Fri, 05 Jun 2026 08:48:05 -0700 (PDT) Received: from ?IPV6:2003:ea:8f14:5400:d967:4840:e11f:4ad4? (p200300ea8f145400d9674840e11f4ad4.dip0.t-ipconnect.de. [2003:ea:8f14:5400:d967:4840:e11f:4ad4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc412sm27730653f8f.4.2026.06.05.08.48.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 08:48:05 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 17:48:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: net: add Realtek r8169 family PCIe Ethernet To: ricardo@pardini.net, nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Sebastian Reichel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-0-8a8857b39daf@pardini.net> <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-1-8a8857b39daf@pardini.net> Content-Language: en-US From: Heiner Kallweit In-Reply-To: <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-1-8a8857b39daf@pardini.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05.06.2026 13:49, Ricardo Pardini via B4 Relay wrote: > From: Ricardo Pardini > > Add a binding for fixed/soldered Realtek PCIe Ethernet controllers > driven by the r8169 driver (RTL8125/8126/8127/8168 and variants). > > The "pciVVVV,DDDD" compatibles are the Open Firmware PCI Bus Binding > spelling, auto-derived from PCI-SIG vendor/device IDs, but they still > need a binding when used in a board DT - analogous to "usbVVVV,PPPP" > compatibles documented in their own bindings (e.g. microchip,lan95xx) > so board DTs attaching properties (fixed MAC, nvmem cell, ...) to > these PCI function nodes can be validated. > The of node seems to be created by of_pci_make_dev_node(). But this function is called for bridges only in pci_bus_add_device(). So where is the node created in your case? Did you test node creation? > Suggested-by: Sebastian Reichel > Signed-off-by: Ricardo Pardini > --- > .../devicetree/bindings/net/realtek,r8169.yaml | 54 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/realtek,r8169.yaml b/Documentation/devicetree/bindings/net/realtek,r8169.yaml > new file mode 100644 > index 0000000000000..6923211ff4c93 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek,r8169.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/realtek,r8169.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek r8169 family PCIe Ethernet Controllers > + > +maintainers: > + - Heiner Kallweit > + > +description: > + PCI function node properties for fixed/soldered Realtek Ethernet > + controllers driven by the r8169 driver. > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + enum: > + - pci10ec,8125 # RTL8125 2.5GbE > + - pci10ec,8126 # RTL8126 5GbE > + - pci10ec,8127 # RTL8127 > + - pci10ec,8161 # RTL8168 variant > + - pci10ec,8162 # RTL8168 variant > + - pci10ec,8168 # RTL8168/8111 GbE This list reflects just some of the PCI id's handled by r8169. Any specific reason for this exact selection? > + > + reg: > + maxItems: 1 > + > + local-mac-address: true > + mac-address: true > + nvmem-cells: true > + nvmem-cell-names: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pcie { > + #address-cells = <3>; > + #size-cells = <2>; > + > + ethernet@0,0 { > + compatible = "pci10ec,8125"; > + reg = <0x10000 0 0 0 0>; > + local-mac-address = [00 00 00 00 00 00]; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index b539be153f6a4..6341de4fadb6c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -134,6 +134,7 @@ M: Heiner Kallweit > M: nic_swsd@realtek.com > L: netdev@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/net/realtek,r8169.yaml > F: drivers/net/ethernet/realtek/r8169* > > 8250/16?50 (AND CLONE UARTS) SERIAL DRIVER >