From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752540AbcHAKtV (ORCPT ); Mon, 1 Aug 2016 06:49:21 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:14967 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbcHAKtR convert rfc822-to-8bit (ORCPT ); Mon, 1 Aug 2016 06:49:17 -0400 From: Amitkumar Karwar To: Heinrich Schuchardt , Nishant Sarmukadam , Kalle Valo CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/1] mwifiex: remove superfluous condition Thread-Topic: [PATCH 1/1] mwifiex: remove superfluous condition Thread-Index: AQHR6xfR3Tkl/1HSNkO2x+3/VTFfi6Az7MWw Date: Mon, 1 Aug 2016 10:46:12 +0000 Message-ID: References: <1469961555-2123-1-git-send-email-xypron.glpk@gmx.de> In-Reply-To: <1469961555-2123-1-git-send-email-xypron.glpk@gmx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-01_08:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608010116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Heinrich Schuchardt > Subject: [PATCH 1/1] mwifiex: remove superfluous condition > > for_each_property_of_node is only executed if the property prop is not > NULL. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > index 7897037..128add8 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > @@ -1482,7 +1482,7 @@ int mwifiex_dnld_dt_cfgdata(struct mwifiex_private > *priv, > continue; > > /* property header is 6 bytes, data must fit in cmd buffer > */ > - if (prop && prop->value && prop->length > 6 && > + if (prop->value && prop->length > 6 && > prop->length <= MWIFIEX_SIZE_OF_CMD_BUFFER - S_DS_GEN) { > ret = mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA, > HostCmd_ACT_GEN_SET, 0, Thanks. The patch looks fine to me. Acked-by: Amitkumar Karwar Regards, Amitkumar