From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 728FB332EDE; Tue, 20 Jan 2026 19:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768938034; cv=none; b=X89RLsUCPYzRSPWQPNFHVL0Bj/pKOtIlkTRavomZ7H/BG29GWDsjDl+mR2aAw7ePncRSGGgVmhEI6Gzy2rDRgPSb+WJBR+zuEN0JMxkwxCWILnfIxsyhZXScx7YDBMw1D2BD0R3S25gUh7oo6K6/cbtojNj5WWHYLMLfjnf7MSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768938034; c=relaxed/simple; bh=A86HiTGdeay1Qm6gVy1xjuUwe/ZurTakL/i4nzwnxfM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j6c8/XyWv+RwkAKOk8mmFN6Ix1mBztsK6kRx4xHQpp54wIc1PZ1SLvHsuY8/482X/WcA2wlQ/cijIc6LObrF6Oy5YhpbwQUqIfeF8nbSJzZ2dNNkdrRkmONLuWbX6WcAP9XOxlTKzTyirqyQrggpz3bQN4JVXw8tqHVDBrYVtOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JvPktp/r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JvPktp/r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAA54C16AAE; Tue, 20 Jan 2026 19:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768938033; bh=A86HiTGdeay1Qm6gVy1xjuUwe/ZurTakL/i4nzwnxfM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JvPktp/r9fF70Yi+kkvVdIvLvdRX6hMlVniyKB22/rSI6V5EvWFmKhirAOKND+Lp/ 6HkPqdn4APlMo5AxNKPl5M3IRLhnk4WBq8y8jNOvnlfRFeUuDsO5HfgRmKhaiY14aQ XWUcBGJ+kosW4SZG0zzaETQg0IVJ6SaOfI90jAOEdONndTIRhj7HccT241CNppSr5s BuDOZXVVNhmHkAbfx5dVCQzMsLkbyiV3/zMtjdz4Zr+wHkjbuDD4xgepPnGZU08GGu APVnzMfQZZcA/9xnGp4OEgH5cjxGGcUZFFnJ64UIQ3kccY/CMNAkSOTFTPDexz6xhm UoANmSzm+CqBg== Message-ID: Date: Tue, 20 Jan 2026 20:40:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: add an alt 128M flash layout To: Marc Olberding , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260120-alt-128-v3-0-a81bdafc00a7@nvidia.com> <20260120-alt-128-v3-1-a81bdafc00a7@nvidia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260120-alt-128-v3-1-a81bdafc00a7@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/01/2026 20:26, Marc Olberding wrote: > Add a 128M layout for the BMC flash chip we didn't boot from. Including > this allows the user to write to each partition on the alternate spi > chip. This dtsi follows the existing standard of using the same layout > as non alt version and prepending `alt` to each partition's name. > > Tested by running on target and catting sysfs nodes You cannot test this patch that way - DTSI is not included by anything. This probably should be squashed with next one because makes little benefit on its own, > for devdir in /sys/class/mtd/mtd*; do > [[ -d $devdir && -r $devdir/name ]] || continue > name=$(<"$devdir/name") > [[ $name == alt* ]] || continue > > size=$(<"$devdir/size") > offset=0 > [[ -r $devdir/offset ]] && offset=$(<"$devdir/offset") > > dev=$(basename "$devdir") > printf "%s name=%s offset=0x%X size=0x%X\n" "$dev" "$name" \ > "$offset" "$size" > done > > mtd10 name=alt-rofs offset=0xA00000 size=0x5600000 > mtd11 name=alt-rwfs offset=0x6000000 size=0x2000000 > mtd7 name=alt-u-boot offset=0x0 size=0xE0000 > mtd8 name=alt-u-boot-env offset=0xE0000 size=0x20000 > mtd9 name=alt-kernel offset=0x100000 size=0x900000 > > Ran dtbs check, no errors from the msx4 dts Drop this sentence, it's implied. There is no point to state obvious, e.g. that you build source code, in the commit msg. It serves no purpose in the git history. You also have changelog for such things, if you want to emphasize. > > running diff between the main and alt flash layouts shows that the only > diff is alt prepended to the partition labels, as expected. ? Not sure what you want to say, but please do not explain us how DTS works (in case this was about DTS). Best regards, Krzysztof