From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbdLIREv (ORCPT ); Sat, 9 Dec 2017 12:04:51 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:46790 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdLIREu (ORCPT ); Sat, 9 Dec 2017 12:04:50 -0500 Subject: Re: [PATCH] Make "Memory Debugging" a menuconfig to ease disabling it all To: Vincent Legoll , Andrew Morton , Ingo Molnar , Byungchul Park , Peter Zijlstra , "Paul E. McKenney" , Josh Poimboeuf , Geert Uytterhoeven , "Luis R. Rodriguez" , Nicholas Piggin , Thomas Gleixner , Linux Kernel ML References: <20171209115333.9086-1-vincent.legoll@gmail.com> From: Randy Dunlap Message-ID: Date: Sat, 9 Dec 2017 09:04:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2017 04:40 AM, Vincent Legoll wrote: > This patch introduces some Kconfig warnings: > > warning: (X86) selects HAVE_DEBUG_KMEMLEAK which has unmet direct > dependencies (DEBUG_MEMORY) > warning: (X86) selects HAVE_ARCH_KASAN which has unmet direct > dependencies (DEBUG_MEMORY) > warning: (X86) selects ARCH_HAS_DEBUG_VIRTUAL which has unmet direct > dependencies (DEBUG_MEMORY) > warning: (X86) selects HAVE_DEBUG_STACKOVERFLOW which has unmet direct > dependencies (DEBUG_MEMORY) > > What would be the best way to fix that ? > > excluding those config options from the "if DEBUG_MEMORY" code > block seems to alleviate the warnings, but is that OK to do ? > > Would moving them out of the if/endif block be acceptable ? That sounds OK to me since none of them have prompts, i.e., they are not user visible, but they are indicators of what the arch supports. -- ~Randy