From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF81C4363C for ; Wed, 12 May 2021 19:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4B2861417 for ; Wed, 12 May 2021 19:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380254AbhELTat (ORCPT ); Wed, 12 May 2021 15:30:49 -0400 Received: from foss.arm.com ([217.140.110.172]:44850 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344065AbhELRAo (ORCPT ); Wed, 12 May 2021 13:00:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5845D31B; Wed, 12 May 2021 09:59:36 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C46D3F719; Wed, 12 May 2021 09:59:34 -0700 (PDT) Subject: Re: [PATCH 5.4 000/244] 5.4.119-rc1 review To: Naresh Kamboju , Greg Kroah-Hartman Cc: open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton , Linus Torvalds , Guenter Roeck , Marc Zyngier , Linux ARM , kvmarm@lists.cs.columbia.edu References: <20210512144743.039977287@linuxfoundation.org> From: Alexandru Elisei Message-ID: Date: Wed, 12 May 2021 18:00:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naresh, Thank you for the report! On 5/12/21 5:47 PM, Naresh Kamboju wrote: > On Wed, 12 May 2021 at 20:22, Greg Kroah-Hartman > wrote: >> This is the start of the stable review cycle for the 5.4.119 release. >> There are 244 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these being applied, please >> let me know. >> >> Responses should be made by Fri, 14 May 2021 14:47:09 +0000. >> Anything received after that time might be too late. >> >> The whole patch series can be found in one patch at: >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.119-rc1.gz >> or in the git tree and branch at: >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y >> and the diffstat can be found below. >> >> thanks, >> >> greg k-h > Build regression detected. > >> Alexandru Elisei >> KVM: arm64: Initialize VCPU mdcr_el2 before loading it > stable rc 5.4 arm axm55xx_defconfig builds failed due to these > warnings / errors. > - arm (axm55xx_defconfig) with gcc-8,9 and 10 failed > > arch/arm/kvm/../../../virt/kvm/arm/arm.c: In function 'kvm_vcpu_first_run_init': > arch/arm/kvm/../../../virt/kvm/arm/arm.c:582:2: error: implicit > declaration of function 'kvm_arm_vcpu_init_debug'; did you mean > 'kvm_arm_init_debug'? [-Werror=implicit-function-declaration] > kvm_arm_vcpu_init_debug(vcpu); > ^~~~~~~~~~~~~~~~~~~~~~~ > kvm_arm_init_debug > cc1: some warnings being treated as errors This is my fault, in Linux v5.4 KVM for arm is still around, and there's no prototype for the function when compiling for arm. I suspect that's also the case for v4.19. I made this change to get it to build: $ git diff diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h index dd03d5e01a94..32564b017ba0 100644 --- a/arch/arm/include/asm/kvm_host.h +++ b/arch/arm/include/asm/kvm_host.h @@ -335,6 +335,7 @@ static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {}  static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}    static inline void kvm_arm_init_debug(void) {} +static inline void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu) {}  static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {}  static inline void kvm_arm_clear_debug(struct kvm_vcpu *vcpu) {}  static inline void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) {} which matches the stub for kvm_arm_init_debug(). I can spin a patch out of it and send it for 5.4 and 4.19. Marc, what do you think? Thanks, Alex > > > steps to reproduce: > -------------------- > #!/bin/sh > > # TuxMake is a command line tool and Python library that provides > # portable and repeatable Linux kernel builds across a variety of > # architectures, toolchains, kernel configurations, and make targets. > # > # TuxMake supports the concept of runtimes. > # See https://docs.tuxmake.org/runtimes/, for that to work it requires > # that you install podman or docker on your system. > # > # To install tuxmake on your system globally: > # sudo pip3 install -U tuxmake > # > # See https://docs.tuxmake.org/ for complete documentation. > > > tuxmake --runtime podman --target-arch arm --toolchain gcc-8 --kconfig > axm55xx_defconfig > > ref: > https://builds.tuxbuild.com/1sRT0HOyHnZ8N5ktJmaEcMIQZL0/ > > > -- > Linaro LKFT > https://lkft.linaro.org