From: "Christian König" <christian.koenig@amd.com>
To: Karl Mehltretter <kmehltretter@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Matthew Brost <matthew.brost@intel.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-fence: Fix dma_fence_enable_signaling() reference in kernel-doc
Date: Mon, 14 Sep 2026 13:46:32 +0200 [thread overview]
Message-ID: <b7e1739e-08f4-4283-a480-f06a9738a0c7@amd.com> (raw)
In-Reply-To: <20260911221100.7079-1-kmehltretter@gmail.com>
On 9/12/26 00:11, Karl Mehltretter wrote:
> The kernel-doc comment of dma_fence_is_signaled_locked() refers to
> dma_fence_enable_sw_signaling, which was renamed to
> dma_fence_enable_signaling by commit 9370a5c664e8 ("dma-buf: rename
> dma_fence_enable_sw_signaling"). Say dma_fence_enable_signaling.
>
> Fixes: 9370a5c664e8 ("dma-buf: rename dma_fence_enable_sw_signaling")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
I'm really wondering why that was not automatically renamed.
Anyway reviewed and pushed to drm-misc-next.
Thanks,
Christian.
> ---
> include/linux/dma-fence.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 158cd609f1036e56668867f092041213cbf30427..3aa85be43aada5a80ea2e1cecc5f76824b434d14 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -501,7 +501,7 @@ dma_fence_test_signaled_flag(struct dma_fence *fence)
> * Returns true if the fence was already signaled, false if not. Since this
> * function doesn't enable signaling, it is not guaranteed to ever return
> * true if dma_fence_add_callback(), dma_fence_wait() or
> - * dma_fence_enable_sw_signaling() haven't been called before.
> + * dma_fence_enable_signaling() haven't been called before.
> *
> * This function requires &dma_fence.lock to be held.
> *
prev parent reply other threads:[~2026-09-14 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 22:11 Karl Mehltretter
2026-09-14 11:46 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7e1739e-08f4-4283-a480-f06a9738a0c7@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kmehltretter@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=sumit.semwal@linaro.org \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®