From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>, Keerthy <j-keerthy@ti.com>
Cc: <linus.walleij@linaro.org>, <t-kristo@ti.com>, <Russ.Dill@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ssantosh@kernel.org>, <haojian.zhuang@linaro.org>,
<linux-arm-kernel@lists.infradead.org>, <d-gerlach@ti.com>
Subject: Re: [PATCH 11/14] gpio: omap: Restore power_mode configuration at resume time
Date: Thu, 12 Apr 2018 15:02:51 -0500 [thread overview]
Message-ID: <b7e2119e-7bf4-a275-be66-0a83705d807e@ti.com> (raw)
In-Reply-To: <20180412143932.GA5700@atomide.com>
On 04/12/2018 09:39 AM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [180412 03:56]:
>> From: Dave Gerlach <d-gerlach@ti.com>
>>
>> Commit 2dc983c565e0 ("gpio/omap: cleanup prepare_for_idle and
>> resume_after_idle") introduces omap2_gpio_prepare_for_idle and
>> omap2_gpio_resume_after_idle to properly configure gpios that are used
>> as wake sources. When entering off mode, omap2_gpio_prepare_for_idle
>> can set a flag indicating off-mode entry is desired, however once this
>> flag is set it is never cleared, so any additional calls to this
>> function, regardless of the mode, have this flag set.
>>
>> This patch restores the pwr_mode flag to 0 in
>> omap2_gpio_resume_after_idle to ensure the flag is not misconfigured
>> during non off-mode operation.
>
> Seems like this should be applied as a fix, can you please add
> a proper Fixes tag?
Correct. And please send it separate.
But not sure about fixes (to many changes) - it has to manually checked for the lowest
kernel version to apply.
--
regards,
-grygorii
next prev parent reply other threads:[~2018-04-12 20:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 3:53 [PATCH 00/14] arm: OMAP: AM437X: Save restores patches for rtc mode with DDR In self-refresh Keerthy
2018-04-12 3:53 ` [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code Keerthy
2018-04-12 16:44 ` santosh.shilimkar
2018-04-16 10:20 ` Keerthy
2018-04-16 10:29 ` Keerthy
2018-05-23 8:47 ` Keerthy
2018-05-23 16:42 ` Santosh Shilimkar
2018-04-12 3:53 ` [PATCH 02/14] ARM: OMAP2: Add functions to save and restore clockdomain context en-masse Keerthy
2018-04-12 3:53 ` [PATCH 03/14] ARM: OMAP2+: omap_hwmod: Introduce HWMOD_NEEDS_REIDLE Keerthy
2018-04-12 14:34 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 04/14] ARM: OMAP2: Add functions to save and restore omap hwmod context en-masse Keerthy
2018-04-12 3:53 ` [PATCH 05/14] ARM: OMAP2: Add functions to save and restore powerdomain context Keerthy
2018-04-12 14:37 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 06/14] ARM: AM33XX: Add functions to save/restore am33xx control registers Keerthy
2018-04-12 3:53 ` [PATCH 07/14] ARM: AM43XX: Add functions to save/restore am43xx " Keerthy
2018-04-12 3:53 ` [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context Keerthy
2018-04-12 14:16 ` Tony Lindgren
2018-04-13 6:16 ` Keerthy
2018-04-12 3:53 ` [PATCH 09/14] ARM: OMAP2: Drop the concept of certain power domains not being able to lose context Keerthy
2018-04-12 3:53 ` [PATCH 10/14] gpio: omap: Drop the concept of gpio banks " Keerthy
2018-04-12 14:22 ` Tony Lindgren
2018-04-12 20:10 ` Grygorii Strashko
2018-04-12 3:53 ` [PATCH 11/14] gpio: omap: Restore power_mode configuration at resume time Keerthy
2018-04-12 14:39 ` Tony Lindgren
2018-04-12 20:02 ` Grygorii Strashko [this message]
2018-04-12 3:53 ` [PATCH 12/14] OMAP: CLK: CLKSRC: Add suspend resume hooks Keerthy
2018-04-12 14:27 ` Tony Lindgren
2018-05-22 7:57 ` Keerthy
2018-05-22 13:39 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 13/14] ARM: hwmod: RTC: Don't assume lock/unlock will be called with irq enabled Keerthy
2018-04-12 3:53 ` [PATCH 14/14] ARM: OMAP2+: prm44xx: Introduce context save/restore for am43 PRCM IO Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7e2119e-7bf4-a275-be66-0a83705d807e@ti.com \
--to=grygorii.strashko@ti.com \
--cc=Russ.Dill@ti.com \
--cc=d-gerlach@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®