From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3844E383326 for ; Wed, 2 Sep 2026 18:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788372275; cv=none; b=BWA9mpfEosPcK0ahuq+yF63bpX1jgOTCMOJzF21607/JW72Tp6eyTU0qX2YCAsgzzIK0n+oAl+UmRYfmQri8haXX73yoTjRon293+YEJy+/iKpDp1Ib1attXxbvj8Z4JjS3WR6o3F82r/wQx5bxVPtd1E378yXsaGat4chpXVl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788372275; c=relaxed/simple; bh=f4WXt6Zuy9y3eY9gmTUA3MWcgBpYzepnscd0xhcL5fs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pcCFNxWm2ns71lN2lHBlE7zK58LtCMEEz+N2XsG+1+eJbvIz7pAnCTMzpvS2KbGpckbm10CCJm/y4CKzam6+SbOTZQQ583f7o+I3Ql159HROErlKfhfmU/lzgXxdf/R8856C2+luhRTqZ0Nhjv1L0NPUGW+UiMDZfaiEDpiab/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XpPca+zo; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XpPca+zo" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9aea40d799so890254a12.0 for ; Wed, 02 Sep 2026 11:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788372273; x=1788977073; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nHZfK559PfK75u7ErNf5bfk1YJgbq213PkKA07r3fYE=; b=XpPca+zoAfvjNUIzHIbTLhbNZSt0Pcl7pTY4p78KZE7pik1TalCEpPI6I0Gca3Kquc 1JW1ONJzQ57oEeoSUbOwSrDATaprZbCtcqtekpW9b4El7c8FEYdHfhex8+xi248BGUAS 2tKBUZnHYtiODj+x+qcDF7ahsIR0kI/crL62AzOWjsq/iS2w7pzajhpQkFNUlG2n6hHN 9GcH6+C10E85Jywm9rWX3ciMkMpHzmYiszAwdT8hxsQIlwVL5uCGjja3SgaQXQKLUbZk xMnecptUYtYu34Bb6IUPv3SvzISAXU98HxI9p990Gr9xR8p11LByElX6xbf39MaKg7M2 YMtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788372273; x=1788977073; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=nHZfK559PfK75u7ErNf5bfk1YJgbq213PkKA07r3fYE=; b=He4SO3IB/SwxUc2/eGkAcUOSyvuHvWBk1N6ch1F6CLKa/dWGn6WarM2LXnmTL+zP+0 WiebTMnkGQj8uUm6zYqZ7+CrWt91eIRqxPIizSgwVCweUPFzEH/dlK9iqiDvZj4hLXIE r6vriRxqOz6ucx/Q4XzPfq+Cog4h+5EHOx0i5Fjsc1HtDU6ejLpL2ibvHEsE5ZpISTV0 PEqHrIpqvq/hEEWnc1p2KLX9JCj49jNTRBhu5TBidCljful6Nh9tTwsfXKREZb9T94YY XkEtn9Okzg+eFtlheQdFym+05XKo5iWUuNK38L+PbZXGwVKwEmhfZq8zJSORxqYhTskH h5ew== X-Forwarded-Encrypted: i=1; AKwUvBydoSg9bSt2oI+NCVp/BwKf0n2+M3lmb4nCjP46/fFhdSrF9E1XTilUZiBnyG0OgLMulUeK2wRs/ZdliUU=@vger.kernel.org X-Gm-Message-State: AFuF++k49KYtoVT18BeedNz1jVGQctFSyNwSe40h/2PfBpeQEeAi1nKS iuAi8cyXsZZyouNQkc6P+0Ezk2DaQE7ZA/w1VolqBQ4HSnk48QLadzSc X-Gm-Gg: AYBFou2dt3VybYp7ZcimvBa4A097gBGmbPcanPGHolXj6eZ5AAGuHEcRupDvncQ9JYp 6fAGjKQPPLXSZh5YNnTadChLd+1wFBTs5qH6x/gaoQ/6is+cGCFhQBL80VK0Dme1f2HCHf5/8ui xrzOvRGz30cPXVddkPZJ+tGrk2ZKHItMPjsKA+Xu85/u28QtPwsJ8mCD+lndjVHer1UgmUNldoS xIrOPYDbJZFv8uT8evLWERIyO9JwJnwemk3PFsZuIXrjHSK1W26jKOy6PLVADVpcy6OWfGFtz0I I+roLUsd3TxDp6z4h+RZs5fGCSBLCFC7EZOWsuBAPjTHPCo3LiRX1nRZFfkAHicd9449/cS+RGO yaWLFioJkHTPyLI4eS4SSe+50zitvgcrkP4YkXnq4tznaPreOAiff9bbvJ3WVzR8CSZcqiaX2cZ dXRN2palbeRynvKjAdMh11ar2wtE40meOhzjVHRPWf6ffzG5xRGGqfPGPQIOg34WhyHKnSGK/H/ WMng8njuwek62uzjAzKem9bRM76PFLIj4tkmQ== X-Received: by 2002:a17:90b:2c8e:b0:398:990e:1587 with SMTP id 98e67ed59e1d1-39aedf25104mr9855099a91.9.1788372273028; Wed, 02 Sep 2026 11:04:33 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08627417sm545440a91.12.2026.09.02.11.04.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 11:04:32 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Wed, 2 Sep 2026 11:04:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells To: Vincent Jardin Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260825-for-upstream-dt-tmp401-vcc-tsc-v2-1-cbc360ec51d9@free.fr> <20260828-weightless-ferret-of-pluck-ef2baa@quoll> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/2/26 07:26, Vincent Jardin wrote: > Hi Guenter, > >> The driver does register thermal zones. Since #thermal-sensor-cells is >> mandatory for using it, I would think that the property is needed. > > agree. thanks. > >> However, not all chips supported by the driver (and this bindings file) >> have more than one channel, so I suspect that the value range might >> need to be "enum: [0, 1]". > > I could switch to "enum: [0, 1]" if you would still prefer it, but > tmp401_probe() sets temp_channel_config[0] and [1] unconditionally (local plus > one remote diode) and tmp432 adds [2] for its second remote. > So each case in this binding has at least two channels and the channel index is always > meaningful. That is why "const: 1" is used, matching national,lm90.yaml, > which covers a mix of 2 and 3 channel chips. > Makes sense. Sorry, I missed that all chips have at least two sensors. Thanks, Guenter > I'll send a v3, that does not change the yaml by that applies the proper comments > per Krzysztof's feedbacks. > > best regards, > Vincent