From: Jens Axboe <axboe@fb.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@lst.de>,
Mike Christie <mchristi@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Ming Lin <ming.l@ssi.samsung.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] skd: fix msix error handling
Date: Wed, 9 Nov 2016 22:54:04 -0700 [thread overview]
Message-ID: <b7f301d3-4bf7-3e4f-3e7f-aed7274a80be@fb.com> (raw)
In-Reply-To: <20161109125555.1440353-1-arnd@arndb.de>
On 11/09/2016 05:55 AM, Arnd Bergmann wrote:
> As reported by gcc -Wmaybe-uninitialized, the cleanup path for
> skd_acquire_msix tries to free the already allocated msi-x vectors
> in reverse order, but the index variable may not have been
> used yet:
>
> drivers/block/skd_main.c: In function ‘skd_acquire_irq’:
> drivers/block/skd_main.c:3890:8: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This changes the failure path to skip releasing the interrupts
> if we have not started requesting them yet.
Applied both patches, thanks Arnd.
--
Jens Axboe
prev parent reply other threads:[~2016-11-10 5:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 12:55 Arnd Bergmann
2016-11-09 12:55 ` [PATCH 2/2] skd: fix function prototype Arnd Bergmann
2016-11-14 8:10 ` Johannes Thumshirn
2016-11-09 15:07 ` [PATCH 1/2] skd: fix msix error handling Christoph Hellwig
2016-11-10 5:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7f301d3-4bf7-3e4f-3e7f-aed7274a80be@fb.com \
--to=axboe@fb.com \
--cc=arnd@arndb.de \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®