mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: "Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Doug Berger" <opendmb@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 6/7] arm: dts: broadcom: Add interrupt-controller flag for intc on BCM2711
Date: Mon, 2 Dec 2024 16:40:04 +0100	[thread overview]
Message-ID: <b80097a1-4c8b-43f1-920f-b31489619111@gmx.net> (raw)
In-Reply-To: <20241202-dt-bcm2712-fixes-v1-6-fac67cc2f98a@raspberrypi.com>

Hi Dave,

Am 02.12.24 um 15:31 schrieb Dave Stevenson:
> BCM2711 DT was producing dtbinding validation errors of
>
> interrupt-controller@40000000: 'interrupt-controller' is a required
> property
> interrupt-controller@40000000: '#interrupt-cells' is a required property
>
> Fix them by adding the required flags.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Did you actually test these changes, because the last time [1] it broke
the boot of RPi 4 and likely for RPi 5, too?

Best regards

[1] -
https://lore.kernel.org/linux-arm-kernel/07154679-42bc-43ba-8b72-62083ed78a4d@gmx.net/
> ---
>   arch/arm/boot/dts/broadcom/bcm2711.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> index e4e42af21ef3..313b1046d74f 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> @@ -51,6 +51,8 @@ soc {
>   		local_intc: interrupt-controller@40000000 {
>   			compatible = "brcm,bcm2836-l1-intc";
>   			reg = <0x40000000 0x100>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
>   		};
>
>   		gicv2: interrupt-controller@40041000 {
>


  reply	other threads:[~2024-12-02 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 14:31 [PATCH 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset Dave Stevenson
2024-12-02 14:31 ` [PATCH 1/7] dtbindings: display: bcm2711-hdmi: Correct bindings for 2712 Dave Stevenson
2024-12-02 15:16   ` Krzysztof Kozlowski
2024-12-02 15:46   ` Rob Herring (Arm)
2024-12-02 14:31 ` [PATCH 2/7] dtbindings: display: Fix BCM2835 HVS bindings for BCM2712 Dave Stevenson
2024-12-02 15:18   ` Krzysztof Kozlowski
2024-12-02 14:31 ` [PATCH 3/7] dt-bindings: gpio: brcmstb: add gpio-line-name Dave Stevenson
2024-12-02 15:18   ` Krzysztof Kozlowski
2024-12-02 15:45   ` Stefan Wahren
2024-12-02 14:31 ` [PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline Dave Stevenson
2024-12-02 15:20   ` Krzysztof Kozlowski
2024-12-02 15:24     ` Maxime Ripard
2024-12-04 19:05     ` Florian Fainelli
2024-12-02 14:31 ` [PATCH 5/7] arm64: dts: broadcom: Add interrupt-controller flag for intc on BCM2712 Dave Stevenson
2024-12-02 15:22   ` Krzysztof Kozlowski
2024-12-02 14:31 ` [PATCH 6/7] arm: dts: broadcom: Add interrupt-controller flag for intc on BCM2711 Dave Stevenson
2024-12-02 15:40   ` Stefan Wahren [this message]
2024-12-02 14:32 ` [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712 Dave Stevenson
2024-12-02 15:24   ` Krzysztof Kozlowski
2024-12-04 19:08     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b80097a1-4c8b-43f1-920f-b31489619111@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=airlied@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=f.fainelli@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mripard@kernel.org \
    --cc=opendmb@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®