From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Xu Liang <lxu@maxlinear.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: mxl-86110: add basic support for MxL86111 PHY
Date: Fri, 15 Aug 2025 19:34:05 +0200 [thread overview]
Message-ID: <b8075cfa-599d-4648-8e33-68062b1a855f@lunn.ch> (raw)
In-Reply-To: <aJ9hZ6kan3Wlhxkt@pidgin.makrotopia.org>
> + /* For fiber forced mode, power down/up to re-aneg */
> + if (modes != LINK_INBAND_DISABLE) {
> + __phy_modify(phydev, MII_BMCR, 0, BMCR_PDOWN);
> + usleep_range(1000, 1050);
> + __phy_modify(phydev, MII_BMCR, BMCR_PDOWN, 0);
> + }
Is a full power down required? To restart autoneg all you normally
need to do it set BMCR_ANRESTART. See genphy_restart_aneg().
> @@ -648,8 +928,24 @@ static struct phy_driver mxl_phy_drvs[] = {
> .set_wol = mxl86110_set_wol,
> .led_brightness_set = mxl86110_led_brightness_set,
> .led_hw_is_supported = mxl86110_led_hw_is_supported,
> - .led_hw_control_get = mxl86110_led_hw_control_get,
> - .led_hw_control_set = mxl86110_led_hw_control_set,
> + .led_hw_control_get = mxl86110_led_hw_control_get,
> + .led_hw_control_set = mxl86110_led_hw_control_set,
That should really be in a different patch.
Andrew
next prev parent reply other threads:[~2025-08-15 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:33 Daniel Golle
2025-08-15 17:34 ` Andrew Lunn [this message]
2025-08-15 17:48 ` Daniel Golle
2025-08-16 8:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8075cfa-599d-4648-8e33-68062b1a855f@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®