From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0D1C7618D for ; Thu, 6 Apr 2023 12:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234767AbjDFMM3 (ORCPT ); Thu, 6 Apr 2023 08:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237363AbjDFMMZ (ORCPT ); Thu, 6 Apr 2023 08:12:25 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E6730FB for ; Thu, 6 Apr 2023 05:12:20 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id t5so9117351ilu.5 for ; Thu, 06 Apr 2023 05:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1680783139; x=1683375139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hiCBgdIy8eq03QW0G9vGas2n0jUS6qAuhUQkgRBSPcQ=; b=NwMNqjFo8wThsLoZnDszHEnFswnjMOJJDEW3C54H8Ov6w67W4Zhl01fE+6JYjZmDm/ xtSEYMk4b8xGQuCxCAf9rX4nV9ba38zCSL8205DjHnRikKbhpAh0tEVjOmszWsUO3fWf xP7huhTdNrrad2FMCqtLrE6Ui5JpB5+vBL2dk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680783139; x=1683375139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hiCBgdIy8eq03QW0G9vGas2n0jUS6qAuhUQkgRBSPcQ=; b=6ModZo568PdEm+YVtgRpri5mSOliSYKADnL0P22ug8pwY+LY2A6uhxmFQmkoKWaMeO 3tkMpU/QB3DmNSVq5QAl/evyjS2tSSd/jOcXdoEUbZchgL7tkbx5I5TmXgzzyCVWhZ3G VH38VaMTNPNk9AvBQg9ld0OReRQJh40ip/070ASAMpZgDj142zdZLJcnU+kBZi0XZx7t 4oNANkMFBgrYaSiNRV69TUFZxRWuxs8k8wfX51Bi/xylEQFbhdLakr1AMtjKYO4aJhBM AyaGIL0PUlqtfY4VZWlBHANapUp+Pk1BTkXvyJxEVtcymjJK41BMx5HkFNu6U5gXKMLf zIxA== X-Gm-Message-State: AAQBX9f6TECuTVMwbay+ra35TZMQCz5TbPogH9mo/Nt74oGHzPC1XBGA vlrEYKY67U2Y1N7iOdhU+uFSWw== X-Google-Smtp-Source: AKy350aXJuXrIoQCoFQrtu/oOr2bIVumcXfubXv54/hMkKw/UalyjaTZpr3nJhbc+I/QXoe/ZBHL+A== X-Received: by 2002:a92:c94d:0:b0:317:eef2:f5cc with SMTP id i13-20020a92c94d000000b00317eef2f5ccmr7197520ilq.10.1680783139465; Thu, 06 Apr 2023 05:12:19 -0700 (PDT) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id l13-20020a92290d000000b00326ca02f30dsm293549ilg.65.2023.04.06.05.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 05:12:18 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 07:12:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] staging: greybus: drop loopback test files Content-Language: en-US To: Greg Kroah-Hartman , linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Johan Hovold , Alex Elder , Jack Schofield , Vaibhav Nagare , greybus-dev@lists.linaro.org References: <2023040613-huntsman-goldsmith-4a41@gregkh> From: Alex Elder In-Reply-To: <2023040613-huntsman-goldsmith-4a41@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/23 3:18 AM, Greg Kroah-Hartman wrote: > The greybus loopback test tool does not belong burried down in a > driver-specific directory. If it is needed, it should be somewhere > else, like in the testing directory. But as the loopback driver is > probably never going to be merged out of the staging directory, let's > just delete the test alltogether for now. If it's needed in the future, > it can be brought back with a revert. > > Also, having an Android.mk file in the kernel source tree breaks some > Android build systems when trying to build from a read-only source tree, > the report of which prompted this being a good reason to remove it as > well. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Jack Schofield > Cc: Vaibhav Nagare > Cc: greybus-dev@lists.linaro.org > Signed-off-by: Greg Kroah-Hartman That's a surprising amount of code. And perhaps there are better ways of exposing this type of information. Anyway, no objection here. Acked-by: Alex Elder > --- > drivers/staging/greybus/tools/.gitignore | 2 - > drivers/staging/greybus/tools/Android.mk | 10 - > drivers/staging/greybus/tools/Makefile | 33 - > drivers/staging/greybus/tools/README.loopback | 198 ---- > drivers/staging/greybus/tools/lbtest | 169 --- > drivers/staging/greybus/tools/loopback_test.c | 979 ------------------ > 6 files changed, 1391 deletions(-) > delete mode 100644 drivers/staging/greybus/tools/.gitignore > delete mode 100644 drivers/staging/greybus/tools/Android.mk > delete mode 100644 drivers/staging/greybus/tools/Makefile > delete mode 100644 drivers/staging/greybus/tools/README.loopback > delete mode 100755 drivers/staging/greybus/tools/lbtest > delete mode 100644 drivers/staging/greybus/tools/loopback_test.c >