From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbdJaJPu (ORCPT ); Tue, 31 Oct 2017 05:15:50 -0400 Received: from mout.web.de ([212.227.15.3]:56754 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbdJaJPq (ORCPT ); Tue, 31 Oct 2017 05:15:46 -0400 Subject: Re: mmc: vub300: Use common code in __download_offload_pseudocode() To: Dan Carpenter , Ulf Hansson , "linux-mmc@vger.kernel.org" , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Tony Olech , LKML References: <7b418db1-ec35-4c85-5d06-45edde56822c@users.sourceforge.net> <20171030121508.zfnsvpsrt25prhr4@mwanda> <20171031084552.mvvn73pfew4rebsd@mwanda> From: SF Markus Elfring Message-ID: Date: Tue, 31 Oct 2017 10:15:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171031084552.mvvn73pfew4rebsd@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:wkcM4H3k5xPmwmuZselAeIg+fXw7nHYwPdttCchiXuKLOC8PLuP DIvSsRvz82RXfi826gQnmHCE8lPi2fBf8nNjACoiwN7Om2awRlJk53TawEzUinntstC/23P XVRlRLCQb7gJ/SaUhA2+CP4SCTjd8PAznGDcXnOJOiPtJUUbyzRVZ9APP4uH9ZZvpkzCaJM h/LF+klmACD7IpNAbho+Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:c8IkcBqXU+I=:TV3O/AumspRp92/VvfCe36 tIFOCdQJBxmvshstLK3W0m/O2vv5kYg9iPRmWxppGtuv+h/6pV5pFo7X6BQdHTJ0Ei1d3XTTw od99nmD50qby9aFAfJR/O/4ic/Zb0ESYo0hQk9REhaV8F2iKSDa/6ag81cUV83wS+q4xnTGiw qMB3wToLdwpYUa+WoDcGfXX/lmz0V2XCvifHtx572MZPCKk43G152dWhAswvYnmAH+n36hL7a HjhthImt2eEjxGB6oUKsezcbPEWmUctybVs2TaxSaUQ9E0cyVbXtYWYZtFhR/U12N0ivDiiPc ceGJtjB0Krm5JEjAktlOAYrfTqkJLu07cEHskaZ7X2WFeArK4zSasBw/GQg5/b9OY8wkq0yB4 jo5GqU6Pn2Zlay52ipKFobQVOFLGxDmCasDjkCVawvxXt6UPi0XFkzSpZR0uqn75SYO7jZwn3 gHNNZm3rdvIbswq7g9T251LAJzgzaHX4TLoov2uxSh5ydvebRXawNCsBxrIuhK9aijyp34mch jGTV5374Dk6KJrxooZvz/RZx48bFSPEchAniAso+HAQ3VYvtTQ9+7AUXerSV0G4pUexQ7MSup OG3acRd4Vs9tE6cvC7/1uFsNeUhmGVG/9Fhu8CmrNiFy0yiw3Yb3W/QhrGIs0DC+aLlCOSsNl wEVtUsNQXyzSohb5wLnxXc2x5TIic2ZD0Gr/4l6PT23NyGAKrUhauYqHLtgFUkW5XBOiuxchQ 20OoaQbgxnbPevOjdnBv4t5YFYgzTOPzD29ThFnT5aUlToQTSCgNy83XnJe40n8aiU4SCps9g WxYq4BcJ18fBWKbq66VJVcEfU9tIYQ5OKAUt9s1XOTYNPqGiVE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> What's the advantage of this patch? The new code seems more complicated >>> to me and GCC automatically reuses duplicate constant strings so there >>> is no memory savings. >> >> It looked to me that the error path got a bit cleaner. However, I >> guess it's matter of taste. >> >> If you insist, I can drop it. > > I'm on the kernel-janitors list so I am CC'd on all of Markus's patches. Do you want that I omit this address from the list of recipients? > It's not my code and I'm tired of being the anti-Markus guy Interesting … But I got the impression that this special relationship resulted also in a few useful side effects. > so this patch is fine. Thanks for another bit of acceptance. > Markus has a tool that finds duplicate strings and he uses gotos > to avoid them. Yes. - The script which I am using for the semantic patch language (Coccinelle software) can not only find this implementation detail but also duplicate source code generally to some degree. > I don't think duplicate strings are a problem They can become an issue for further considerations if inappropriate error messages were used for example. There are more statement combinations which can be improved a bit more. > or that it's a good idea to send over a hundred patches using this method. The change acceptance is varying as usual. > But many people have explained that to Markus already I hope that my contributions can improve the affected software in some areas. > and that's not the bigger picture which is about error handling and labels. > What I like are labels that are necessary and self explanatory. It seems that this is a topic where you got strong opinions about. > You're reading along and you're like "what happens at the err" label? Would you accept any further adjustments around questionable jump targets? Regards, Markus