From: Andrew Lunn <andrew@lunn.ch>
To: Xiangqian Zhang <zhangxiangqian@kylinos.cn>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] net: mii: Fix the Speed display when the network cable is not connected
Date: Fri, 10 Jan 2025 19:03:46 +0100 [thread overview]
Message-ID: <b80d02e7-3eae-4485-bf54-84720dbb6a5d@lunn.ch> (raw)
In-Reply-To: <20250110092302.2717512-1-zhangxiangqian@kylinos.cn>
On Fri, Jan 10, 2025 at 05:23:02PM +0800, Xiangqian Zhang wrote:
> Speed should be SPEED_UNKNOWN when the network cable is not connected
What driver is actually using this? Have you really experienced this
problem? The mii_ code is really old, i doubt there are too many
drivers in use today which use it. So a bit more explanation would be
good.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-01-10 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 9:23 Xiangqian Zhang
2025-01-10 18:03 ` Andrew Lunn [this message]
2025-01-11 13:22 ` [PATCH v2] " Xiangqian Zhang
2025-01-14 22:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80d02e7-3eae-4485-bf54-84720dbb6a5d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangxiangqian@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®