From: "Arnd Bergmann" <arnd@arndb.de>
To: "Otavio Salvador" <otavio@ossystems.com.br>,
"Shawn Guo" <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
"Alistair Francis" <alistair@alistair23.me>,
"Fabio Estevam" <festevam@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Mark Brown" <broonie@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Russell King" <linux@armlinux.org.uk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Stefan Hansson" <newbie13xd@gmail.com>,
"Stefan Wahren" <stefan.wahren@chargebyte.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config
Date: Wed, 24 May 2023 08:48:26 +0200 [thread overview]
Message-ID: <b8166ed7-2d3b-4bdd-b597-f0aeddb7ecdc@app.fastmail.com> (raw)
In-Reply-To: <20230523212829.2539417-1-otavio@ossystems.com.br>
On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote:
> The KERNEL_GZIP is used in most config and is the default, there is no
> clear reason to diverge so let default be used.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
I don't mind that change, but it seems odd to single this one out, as
there are many other options in that particular defconfig that
stick out more, picking LZO seems like a reasonable choice for slightly
faster booting, though ZSTD would be the more modern choice.
If you are looking into cleaning up this file, maybe see if we can
kill off these options:
CONFIG_EXPERT=y
CONFIG_ARCH_FORCE_MAX_ORDER=13
CONFIG_CMDLINE="noinitrd console=ttymxc0,115200"
CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files
CONFIG_SMC91X=y
CONFIG_SMC911X=y
CONFIG_SMSC911X=y
CONFIG_STAGING=y
CONFIG_STAGING_MEDIA=y
CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y # select EXT4 instead
CONFIG_ISO9660_FS=m
I have not investigated why any of them were added originally,
so it's likely that some are actually needed.
Arnd
next prev parent reply other threads:[~2023-05-24 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 21:28 Otavio Salvador
2023-05-23 21:54 ` Fabio Estevam
2023-05-24 6:48 ` Arnd Bergmann [this message]
2023-05-24 10:47 ` Francesco Dolcini
2023-05-27 12:44 ` Shawn Guo
2023-05-27 13:29 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8166ed7-2d3b-4bdd-b597-f0aeddb7ecdc@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mpe@ellerman.id.au \
--cc=newbie13xd@gmail.com \
--cc=otavio@ossystems.com.br \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®