From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4D716C437 for ; Thu, 11 Jul 2024 16:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720715249; cv=none; b=SaM4wsqLI0WVekSQ7yutcpUUY5kIj/tTYJqzG3Qn3DS6gkdfxIpkIA1Ez8SuzfuqVWdYbOreN3jXFy9WtSkYWvypDB2GJH7tFXwL+S9wG2N2SrFgV5/+j69C7TyfbCx7vFXTHkM3Le8PnqyX7S+YtwhnaK+1pHFd5St8oyem17k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720715249; c=relaxed/simple; bh=7Npujt/HI+JKoyoMEPQGekvvaq3PC5E7qr0zDHfpoCA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YgvLirv7NCsRSSrwyYFpLoQYYxvwvdcrjxUa5+K+U9If8PkEPhL1K1J1JYmb3iLVXSqif+nv1gM/EaSkY4htSig7smAphA9qD1UU8NvvsMNPQeX5AgxEz33vD8Le5PTTwbKd06EKDSMsSc+7I6/yRDiQyRtDFlaSpGNuVTBxZzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=dyD5K72Z; arc=none smtp.client-ip=44.202.169.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="dyD5K72Z" Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id RiAHsWjO01zuHRwddsPguO; Thu, 11 Jul 2024 16:27:21 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id RwdcsHgyURn6WRwddsPOjf; Thu, 11 Jul 2024 16:27:21 +0000 X-Authority-Analysis: v=2.4 cv=KbTUsxYD c=1 sm=1 tr=0 ts=669007e9 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=frY+GlAHrI6frpeK1MvySw==:17 a=IkcTkHD0fZMA:10 a=4kmOji7k6h8A:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=Q-fNiiVtAAAA:8 a=bLk-5xynAAAA:8 a=yPCof4ZbAAAA:8 a=RC4BnwySBbfqoxRRKE4A:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Fp8MccfUoT0GBdDC_Lng:22 a=zSyb8xVVt2t83sZkrLMb:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7RxJ21FjXXoxPmpAMaOPM/NGSLf98n+q9lHoeiSK3rU=; b=dyD5K72ZxHOe6gUh2eDT6OikmS HaefSlR5n3lItPNf/YZG8LYP+WW3DhL/VqHZ29sVoI21Rcu+V6bNQzKIhgC5yHr13annwFe9lruDw a8NnenPgMuozXZTp0EUiE4V7uYfVkItc5NuEwaKbRycIz8su2FXcL469cWwDgkDaGeiAuwdbaOnSd pFD3X8lYPY4bGEUKwQG1X4ddUA2+ivBotRvV5USBr2fkBFOJ5A+RvwG4VSUjFR5RIRHASUHuqxUfr JMk2Uv83iPuSHRF225vTQi350Pfh0A9BFDJ3KLkrGxP7yrXpMflTTnwRx0PMkYAejhM/aYTDBdRS1 OuqoetpA==; Received: from [201.172.173.139] (port=40030 helo=[192.168.15.4]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1sRwdc-0006S7-0x; Thu, 11 Jul 2024 11:27:20 -0500 Message-ID: Date: Thu, 11 Jul 2024 10:27:18 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scsi: megaraid_sas: struct MR_LD_VF_MAP: Replace 1-element arrays with flexible arrays To: Kees Cook , Kashyap Desai Cc: Sumit Saxena , Shivasharan S , Chandrakanth patil , "James E.J. Bottomley" , "Martin K. Petersen" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20240711155823.work.778-kees@kernel.org> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <20240711155823.work.778-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.173.139 X-Source-L: No X-Exim-ID: 1sRwdc-0006S7-0x X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.4]) [201.172.173.139]:40030 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 58 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfL6ycp2z882YsnvfwjiiaGuJIj7B6EdHmr/tpedpzNvlx8hSjOBouWuj1lx8/Tg3fXfQ0vl73ljfI2O6z+kGiafrh9Jygf1vp2iw3Mzl96mmmfeXfAl5 kJlreHdDQlK8X6rjLuYeTt28zzWV9KjeivsZbSJli+uj3Jm5YWqnoHXbYKScCU5zwOFilFXUiDkZF3p5VjBc7/r3HQ0o7ixPzgXLjXuFiAIbN4uo/qRmKDn8 On 11/07/24 09:58, Kees Cook wrote: > Replace the deprecated[1] use of a 1-element array in > struct MR_LD_VF_MAP with a modern flexible array. > > No binary differences are present after this conversion. > > Link: https://github.com/KSPP/linux/issues/79 [1] > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > Cc: Kashyap Desai > Cc: Sumit Saxena > Cc: Shivasharan S > Cc: Chandrakanth patil > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: megaraidlinux.pdl@broadcom.com > Cc: linux-scsi@vger.kernel.org > --- > drivers/scsi/megaraid/megaraid_sas.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h > index 5680c6cdb221..84cf77c48c0d 100644 > --- a/drivers/scsi/megaraid/megaraid_sas.h > +++ b/drivers/scsi/megaraid/megaraid_sas.h > @@ -2473,7 +2473,7 @@ struct MR_LD_VF_MAP { > union MR_LD_REF ref; > u8 ldVfCount; > u8 reserved[6]; > - u8 policy[1]; > + u8 policy[]; > }; > > struct MR_LD_VF_AFFILIATION {