From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C4ECC4332F for ; Fri, 18 Nov 2022 13:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235200AbiKRN37 (ORCPT ); Fri, 18 Nov 2022 08:29:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241597AbiKRN32 (ORCPT ); Fri, 18 Nov 2022 08:29:28 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D883D532E6 for ; Fri, 18 Nov 2022 05:29:26 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id j16so8179653lfe.12 for ; Fri, 18 Nov 2022 05:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q/TyOqr73oo6gB6yR08kHAfoWVVQLDrClTo0sJTWwhc=; b=CmrWBXFllKIQAsoSTeOMuz2gdKXRU9BA6YQPz6GcNHw8gIIb2PyFCYmnzOn5Wm0OK0 jUN07r6dzLtojBMomFaxN6WRPZ0nhvGH0A1AN2owJjGfUN+3lRO6NYdKktYQipEkTfOb DrJeCsufw8b69Yp+fQqqj8pVaHYkchrK2ibwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q/TyOqr73oo6gB6yR08kHAfoWVVQLDrClTo0sJTWwhc=; b=hG0YfbDLtssfM5qKQE0ku68S5rPIyMXldkW9FLdehyQFoGKxmKfBYk6dvji5VfAEpS SHCLzOkcH5OSZDdy9Fmfq4S9IUJEaDlxGG3ms35mgvW6sKCP+TPYrcPsLVbddEve8KQm Krsy9oYNMakrMcCkHGRGTefcsvBJVZuBul02typZC5if3HuPDWAkzPbfz+C/XI6lzVZg P2hiR24/JwffrYRgoxvFQ4PxkB6b3gedMqWHHImq5bd5XAiUKpnSHCL+v21jH/BOYqXr 3cbJafnpZLbT3jdLzp11mSP8bCb+wp4S+ZPKpH5dyMmji7wiFl2hoKbpfNEJjrQqsmUX 0IuA== X-Gm-Message-State: ANoB5pm3CQBeGqRNm/3K0puJhHvlrQmMAAT5pmBgGnMbcgTkYbAt08zv 0O4IJBNppOfNbvwUucyAGnS/iA== X-Google-Smtp-Source: AA0mqf7PW78FYCP+kjvydfHU5oMH2AIMPUs7xKcByPxInuLc8lVC/femYfseh7ZMaBgKL53nRyPDPA== X-Received: by 2002:a05:6512:34c7:b0:4a2:2b23:f17f with SMTP id w7-20020a05651234c700b004a22b23f17fmr2285963lfr.688.1668778165188; Fri, 18 Nov 2022 05:29:25 -0800 (PST) Received: from [172.16.11.74] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id 13-20020a2e164d000000b00277078d4504sm656431ljw.13.2022.11.18.05.29.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 05:29:24 -0800 (PST) Message-ID: Date: Fri, 18 Nov 2022 14:29:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] iio: addac: ad74413r: fix integer promotion bug in ad74413_get_input_current_offset() Content-Language: en-US, da To: "Sa, Nuno" , "Tanislav, Cosmin" , Lars-Peter Clausen , "Hennerich, Michael" , Jonathan Cameron Cc: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20221118123209.1658420-1-linux@rasmusvillemoes.dk> From: Rasmus Villemoes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2022 14.17, Sa, Nuno wrote: >> Casting to int avoids that promotion and results in the correct -32767 >> output. >> >> Signed-off-by: Rasmus Villemoes >> --- > > After adding proper Fixes: tag, > > Reviewed-by: Nuno Sá That would be Fixes: fea251b6a5db (iio: addac: add AD74413R driver) Thanks, Rasmus