From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9954AC4332F for ; Tue, 15 Nov 2022 17:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbiKORjH (ORCPT ); Tue, 15 Nov 2022 12:39:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbiKORiz (ORCPT ); Tue, 15 Nov 2022 12:38:55 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D9442F3B1 for ; Tue, 15 Nov 2022 09:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668533882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCQ4pMfZCOZ5jMpOJsoLzuHaICjEUdTEXR6Q3zx1EEY=; b=cado30NiPXa/d8wk7TPzWwXc5fT542fcUJePUbzViiBVeOW6L63Zi+3tgut2l80C6kklTN uNRDMCP40QyNFZPH6L7xJIblsgJBY3Czt/zBUdZDvmWEQSoirbVCudmj2NUb4O/MTjGN0+ SGwwxILjPjTIRN4zauNyqCSewPLhPZs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-76-ZlKCM5FOOMmzn-gkzU_tgg-1; Tue, 15 Nov 2022 12:38:00 -0500 X-MC-Unique: ZlKCM5FOOMmzn-gkzU_tgg-1 Received: by mail-ej1-f71.google.com with SMTP id xh12-20020a170906da8c00b007413144e87fso7686009ejb.14 for ; Tue, 15 Nov 2022 09:38:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XCQ4pMfZCOZ5jMpOJsoLzuHaICjEUdTEXR6Q3zx1EEY=; b=3AQpWt2U8vVRYyzLDlUNyuN3M4uvSlxI2VktgBUyGt+491Ow3ioarlRhQoaAUzNQ7k 1ISyO6ECpr46fcIVy1X/C+895Aq3PwhULF2NYyC25UY75rMFiTesrVhDPHZ74QvyB3Yq xU+vwfMk54I+Jxg9LKdhrecmOstbjvLkTc/b7nzz5dEKAHjWe8xdaEafHrAfDbR4wLVw yRrjUF1z0xqAfeO6jq3NMrcC4vbfIQtaFFWc4jDNr6VE1MR4bA5NjxIDZfZgbw8ULYTz aIlxGT/9j1CTED3iPOxJwtZ/x8y0FPCQRA+gTUGq19rm5xFJoz0mzUbR650qB8onDiXr C08w== X-Gm-Message-State: ANoB5pllSlurosW2GqlpV8T29j8ubx2KahzfiCz5qjbAdAw7/Q1dCXAC 7+Lh5yznp/tZt6456BHmNhS0lcbTzQvJ77TY6wByc/BFt5NK8DHkvooN7iQX6/Ye/eY01oS4WVU /i/C4JL5m+cgTSSwo7BItRdC5 X-Received: by 2002:a17:906:6b02:b0:7a5:f8a5:6f80 with SMTP id q2-20020a1709066b0200b007a5f8a56f80mr15729537ejr.202.1668533879754; Tue, 15 Nov 2022 09:37:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5IwpWZHIj8mnq8C9lxBnDSKXKaXz3PjdyKm7Lb9V1W5H/CrRTh9RaKvgSuEpkkt16OYKskmQ== X-Received: by 2002:a17:906:6b02:b0:7a5:f8a5:6f80 with SMTP id q2-20020a1709066b0200b007a5f8a56f80mr15729523ejr.202.1668533879544; Tue, 15 Nov 2022 09:37:59 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.googlemail.com with ESMTPSA id f10-20020a170906c08a00b0078c47463277sm5819739ejz.96.2022.11.15.09.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 09:37:58 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 18:37:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH linux-next] KVM: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Content-Language: en-US To: Sean Christopherson , guo.ziliang@zte.com.cn Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <202211150858513761518@zte.com.cn> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/22 18:31, Sean Christopherson wrote: > On Tue, Nov 15, 2022, guo.ziliang@zte.com.cn wrote: >> From: guo ziliang >> Fix the following coccicheck warning: >> /virt/kvm/kvm_main.c: 3849: 0-23: WARNING: vcpu_get_pid_fops >> should be defined with DEFINE_DEBUGFS_ATTRIBUTE >> >> Signed-off-by: guo ziliang >> --- >> virt/kvm/kvm_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 2719e10..6e58aec 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val) >> return 0; >> } >> >> -DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n"); >> ++DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n"); > > NAK, third time is not a charm. > > https://lore.kernel.org/all/20221101072506.7307-1-liubo03@inspur.com > https://lore.kernel.org/all/20220815031228.64126-1-ye.xingchen@zte.com.cn Screw it, I'm going to send a pull request just to delete that file. Paolo