From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB194266B1 for ; Thu, 2 Jul 2026 09:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782984521; cv=none; b=ZD5lp0Wya8MxbfilHW2fNDtvUUHrHfDMAjl2zBtCV6wmqdAFPKU7QkoSBt3SSffFLrUiLKupucP65K2S4ii/0dX9RxNFWwvz1wUlVY3DUMcw25c39RlFbKQ+z/kGbWGKXJh9eQo4yYPzJp6YF8KWSQdjiPKCxDlK5mR9ltPl1I0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782984521; c=relaxed/simple; bh=ord1rspkjMh6vVxNgvwjzy4OsLQIgtGKKriwINUPMpY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qx/mLDqWTrwD9mvBLHaLvqBacmdJzwxzakNQVx5kZzRFEFHRy553GmDQk69s9SqGu77KH308fBOZhSfRYHrC8VXamhl92M0MsEfvvD6v+om9oLe0vhPxsFK42YmYuItt5ZYyYx+70xUY5JhzeZprSU5ioJqdajlnKWGbtTxA+cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YQYaexdT; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YQYaexdT" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-39aef0b048bso1027921fa.2 for ; Thu, 02 Jul 2026 02:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782984518; x=1783589318; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=r0zPwWUyPadxaQfjwDx9HdrEaUrpGJfxmRrHbmv0dro=; b=YQYaexdTUYAtdzI5NH0jhExR8JRDWYN7NKyityvCvkG0CGq6DxVN2TCob1NOX2EF7L UK4+lVhhbwmZf5FlzNs+XXXsBe9GbNIyC1wbjbFp1s7YeFwAbtGB5PooLThWejdQbL2u LNQIiPgQA5PU1719aXuaJSQAJL0xAfr3cheSEWlWIhVMcBJ5zTyd8fm7s+JsSHaHZ7h0 DoHo0/y6SbGxwwIjBa7INa1C9dOHxzAjprJPwsLvVN8sCOb/5YHy7Pw/pnx3YAEp4Vky wAJa+89qHOaqArj4awKg0FHgr7gTWAw43ZeJ7PIXflMnkCUNfqNYIBfq6qCjpa4HN2pp /HEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984518; x=1783589318; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r0zPwWUyPadxaQfjwDx9HdrEaUrpGJfxmRrHbmv0dro=; b=KOe7Ef/huRy8Q9n7tekptRUev3E7568zUrhPBN810f4n+Jvvm3ZaHdxkyGrClN4NBx N4Jl/FSGYSkpKFXw4kd49JuNjxT91xbVqTYj770nKSvTCycR4toZQxzka2WCOJJ373ep wEWgNI5kGf4OhgVPnAa6ychM0hQo+OtuD4yWHstB9k16Gy/OHk25drbCNRbwtOe4lZLh A53mOoSyHJK5iKFVF+qjDQoWnlfeN7qonKmG+1LjHeOajbG+5YwSkAEywi8gHeVvlFQU x06piq+caJObkHBjJlNBnxgPGqRmkD9Yi6ja+A8deNFX2Ci9DWMkohYy6rLXS80ns0yZ 6cSQ== X-Forwarded-Encrypted: i=1; AHgh+Rr4zcG07TtvXRW9sJYTk8WJ/ptG+4A+9XG0hl9WdGm6/T5iTF05SgDDQmyxm4EfZ/trcdm5AkmEcFRgrbo=@vger.kernel.org X-Gm-Message-State: AOJu0YzMDrWGvMSwfWwn1I6AkZWE/WU6oZuCPRFVo9IMjs/Ttf29Yh+R ySlfdPKzl2RUNG1ADeRsDDyviYDWgHbheHBBqP7TADtCmES3d4MHykB18ckSzScIMxY= X-Gm-Gg: AfdE7cmYo0nP0x1ByoqWsw7eScgoOFtY1jQS2aK+R9r6nvzAOO061GLnTkz6+UbubyM 2KVc4yQXMNrNXvGM2IbN8NzZkwd7H6XHUOyn07uB2SUnPIIeJBG13HcBQ8ryt2ZlJKZjvuaHErk w2opmzL7BpuNuJNba7kLMfzojwJBnto6MUSRZlu4RsSLo3H9VnUj93vJv5CkGN/bNyFv1MkGkZm 2rrCKX71a92eE+GPs/KEahCgtcuFxkROWLv8re4hlQfCAwrj/5LuetrAQfaP/ieJ2b6Ba8Xow++ 6emWXAbkyxREHyNipQCEvL0IcfVUa8l4G7yrs/IYXNDcDxg7TSQ7g2Z2qGk7kO914k39YhgIyVw zUasC7P5lSj3ywg1olYFAslCbANAhESXsN07LiQXfPbCCKmvXhA4Bep+zdscawwmmzWT7XjW8LX jVNqXGAREru86Zy/z8Ag9YTG/cAcm0ztgcHSFqO5Lds2RLt+IiXpmlmSwSj98nuO4rz7E= X-Received: by 2002:a2e:be03:0:b0:396:67c6:9338 with SMTP id 38308e7fff4ca-39b33c3891fmr7815541fa.0.1782984517842; Thu, 02 Jul 2026 02:28:37 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b38004dbasm4980591fa.40.2026.07.02.02.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:28:37 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 12:28:36 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260523-x1e-csi2-phy-v8-0-a85668459521@linaro.org> <20260523-x1e-csi2-phy-v8-1-a85668459521@linaro.org> <7c564df8-5c5a-4b43-806e-5e017e5c51db@kernel.org> <6b6492a4-7610-4dce-a81c-8dc0387a4061@linaro.org> <1c583e24-09db-4d90-8f32-d3d3961188a0@linaro.org> <3e2e6184-e020-49cc-9a4b-609c05aed846@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <3e2e6184-e020-49cc-9a4b-609c05aed846@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/2/26 11:46, Bryan O'Donoghue wrote: > On 02/07/2026 09:31, Vladimir Zapolskiy wrote: >>>>> phy-cells = 1 with CPHY/DPHY specified in the consumer, as was Rob's >>>>> suggestion will specify the mode. >>>> >>>> This cell is just not needed, and unneeded complexity should not be >>>> added. >>> >>> I'm going to stick to Rob's initial guidance on this. >>> >>> https://lore.kernel.org/linux-media/20250710230846.GA44483- >>> robh@kernel.org/ >>> >> >> Sure, the discussion will be continued abouve v9 of the series, it's >> just a chance to do it now. Rob properly pointed out, that the invented >> "phy-type" is not needed at all. > > I'll quote here > > >> + phy-type: > >> + description: D-PHY or C-PHY mode > >> + enum: [ 10, 11 ] > >> + $ref: /schemas/types.yaml#/definitions/uint32 > > > Perhaps putting this in phy cells would be better because the consumer > > decides on the mode. > > A clear instruction which I'm implementing. It has no contradiction with what I've said above, you have a chance to discuss the matter now or at v9 time. >> Ther fact is that the whole placement of the CSIPHY to phy subsystem >> looks execessive, since you add a driver for a media device, there will >> be nothing PHY driver specific left in the CSIPHY driver but name. > No, a block with its own pins, external voltage rails, even its own > specific votes to scale individual clocks, is a distinct PHY. > > There will be no further CSIPHY init sequences getting buried in CAMSS. > It is well past time to dispense with the monolith. > Again, there is no contradiction with what I've said above, so far there is no argument to support CSIPHY driver registration within phy framework. -- Best wishes, Vladimir