From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Initial Exynos850 ACPM support for exynos-acpm
Date: Sat, 3 Oct 2026 16:08:19 +0200 [thread overview]
Message-ID: <b8270c62-08fb-467d-9cd3-af06a70ad1ee@kernel.org> (raw)
In-Reply-To: <20260929-exynos850-acpm-firmware-support-v3-0-473a69fc8a3d@linaro.org>
On 29/09/2026 04:11, Alexey Klimov wrote:
> This series adds support for the Exynos850 SoC to the Samsung ACPM
> firmware IPC driver.
>
> The Exynos850 contains an APM co-processor that handles IPC messages for
> clocks, power, thermal management, and PMIC control. While it uses the
> same underlying ACPM communication machinery and protocols set as
> the GS101, the exact implementation details vary between the two SoCs.
>
> Those protocol-specific differences will be managed individually by the
> corresponding protocol drivers. However, a dedicated compatible string
> is still required for the core IPC driver because the Exynos850 firmware
> utilizes a different initialisation data base offset.
>
> First patch updates the google,gs101-acpm-ipc dt-bindings to include the
> new "samsung,exynos850-acpm-ipc" compatible string and adds clocks
> descriptions for clocks that can be controlled via ACPM or by Linux
> directly.
>
> Second patch adds the corresponding match data, base offset, and clock
> device name to the exynos-acpm firmware driver.
>
> There is a dependency for driver changes on clk-acpm exynos850 series
> which seems to be accepted/merged:
> https://lore.kernel.org/linux-samsung-soc/20260915-exynos850-acpm-clk-v2-0-ffad4a6b3fb1@linaro.org/
I don't understand this dependency. Why does a firmware driver depend on
clock one?
You do understand that mentioning fake dependencies only stalls the
patchset? I would have applied it now, but because of this question, it
will wait and due to conferences might miss this merge window.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-10-03 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 2:11 Alexey Klimov
2026-09-29 2:11 ` [PATCH v3 1/2] dt-bindings: firmware: google,gs101-acpm-ipc: document Exynos850 compatible Alexey Klimov
2026-09-29 2:11 ` [PATCH v3 2/2] firmware: samsung: acpm: add Exynos850 support Alexey Klimov
2026-10-02 14:43 ` Peter Griffin
2026-10-03 14:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8270c62-08fb-467d-9cd3-af06a70ad1ee@kernel.org \
--to=krzk@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®