From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6069DC4332F for ; Thu, 3 Nov 2022 08:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbiKCIxr (ORCPT ); Thu, 3 Nov 2022 04:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbiKCIxm (ORCPT ); Thu, 3 Nov 2022 04:53:42 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A13CC763; Thu, 3 Nov 2022 01:53:41 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1DEEA5C00E7; Thu, 3 Nov 2022 04:53:39 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 03 Nov 2022 04:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1667465619; x=1667552019; bh=YMTHNrTlQM ptD5TGpQsFwcoklQykQSuoBCCpqi+5nsQ=; b=L8DypVymW/aai7Z97N5qeQkTIC vJLb8xggujFa3Ve3PYExqM0YFCNuZ6bRTgwZuqgZt9Rc+fvLlgh6Rrp9f5Rgv+3A ZgZ7mse0SUwAWisrKamJOPhaDYBsFf8FRYDLsZ9n0EAjqAttOgIms6pI9UpCM0Qz 7658QRVFmd/CjrHNiwkaDIkqxfSO1UdTzeOejdR73K4JCrX/4MxKWJVT68Qi/IF8 8wOtBV1QRTL24kCRWpflVC2kpmmVZrlzABdbuqmCoWmPWOF5OCHyAPqj/FKEXEwz DjtmMYiC+0faYxmvyxoEfv3pgfWhy5D+jKvBog6vmJdutee3Q0qnWi3mo4uA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667465619; x=1667552019; bh=YMTHNrTlQMptD5TGpQsFwcoklQyk QSuoBCCpqi+5nsQ=; b=OkQuzP47yYOJ8/ZOwc+ABfktwJD8XYfncv/NdEYtEENZ 8YCLW162Tgj6ldJ5SpvuhWNc4GM3SrUhzmLUbMXcJ5eGYFX1YQsTL9xxAY0RoaTU WMxZOdYU2IoC2/9YMsFumSk+6kr7OYqRNfgNecW/6eHpeA8ZQbSUdYBxC5LnJnMK fwMVghuIFLMHg6B3Mcy6OkzpPkgznsH3d1Mm9/+2Ohz2QJT2CqdixO1NjvOArb4n fYBhaiotMiiAiJi04Fc2/GDfWwnJl90bXywRoR9gnjR3pTuU98XVjGjpTgJYwxh/ vJgZeberVR3gt1sdMY0VnnxU9X5FLYUBQa76iSIygA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudekgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffgeffuddtvdehffefleethfejjeegvdelffejieegueetledvtedtudelgfdu gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0C2CDB603ED; Thu, 3 Nov 2022 04:53:37 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1087-g968661d8e1-fm-20221021.001-g968661d8 Mime-Version: 1.0 Message-Id: In-Reply-To: <20221103081942.3529-1-zhuyinbo@loongson.cn> References: <20221103081942.3529-1-zhuyinbo@loongson.cn> Date: Thu, 03 Nov 2022 09:53:17 +0100 From: "Arnd Bergmann" To: "Yinbo Zhu" , "Rob Herring" , "Krzysztof Kozlowski" , "Hector Martin" , "Lubomir Rintel" , "Conor.Dooley" , "Linus Walleij" , "Hitomi Hasegawa" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "Brian Norris" , "Sven Peter" , loongarch@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] soc: loongson: add GUTS driver for loongson-2 platforms Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 3, 2022, at 09:19, Yinbo Zhu wrote: > The global utilities block controls PCIE device enabling, alternate > function selection for multiplexed signals, consistency of HDA, USB > and PCIE, configuration of memory controller, rtc controller, lio > controller, and clock control. > > This patch adds a driver to manage and access global utilities block > for loongarch architecture Loongson-2 SoCs. Initially only reading SVR > and registering soc device are supported. Other guts accesses, such > as reading PMON configuration by default, should eventually be added > into this driver as well. > > Signed-off-by: Yinbo Zhu Looks ok to me. I can take the new driver through the SoC tree, so please send it to soc@kernel.org once there are no more remaining review comments that need to be addressed. One last thing from my side, with that addressed, please add my Reviewed-by: Arnd Bergmann > +config LOONGSON2_GUTS > + tristate "Loongson-2 GUTS" > + depends on LOONGARCH || COMPILE_TEST > + select SOC_BUS In the one-line description, please spell out GUTS, since this is not a generic term but apparently is something that is only used on Loongarch and Layerscape. Just for clarification: is this derived from the same IP block that NXP are using, or is this just coincidentally named similarly? Arnd