From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "Vishal Moola (Fractile)" <vishal.moola@gmail.com>
Cc: <driver-core@lists.linux.dev>, <gregkh@linuxfoundation.org>,
<rafael@kernel.org>, <dakr@kernel.org>,
<linux-kernel@vger.kernel.org>,
<dawid.osuchowski@linux.intel.com>
Subject: Re: [PATCH] driver core: platform: Simplify platform_device_alloc()
Date: Mon, 28 Sep 2026 09:56:18 +0200 [thread overview]
Message-ID: <b82f156b-debe-46f9-b7b4-6917d775cb2a@intel.com> (raw)
In-Reply-To: <arZrOu36s26e-mPq@fedora>
On 9/25/2026 2:38 PM, Vishal Moola (Fractile) wrote:
> On Fri, Sep 25, 2026 at 11:39:28AM +0200, Cezary Rojewski wrote:
>> There is no need to double check the 'pa' object.
>>
>> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>
> Minor nit: The commit message could be more descriptive (i.e. something
> like "Check whether platform_object allocation failed once instead of
> checking for success twice"). Although I imagine compilers are smart
> enough to avoid double checking anyway (I haven't looked at the
> generated code myself).
>
> Either way the new code is more readable, so LGTM.
>
> Reviewed-by: Vishal Moola (Fractile) <vishal.moola@gmail.com>
Thank you for the review. Given the current AI era, I tend to leave very
straight-forward messages in contrast.
And yes, I believe the compiler would optimize this out anyway but the
readability is the key benefit here.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-09-28 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 9:39 Cezary Rojewski
2026-09-25 12:38 ` Vishal Moola (Fractile)
2026-09-28 7:56 ` Cezary Rojewski [this message]
2026-09-26 8:29 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82f156b-debe-46f9-b7b4-6917d775cb2a@intel.com \
--to=cezary.rojewski@intel.com \
--cc=dakr@kernel.org \
--cc=dawid.osuchowski@linux.intel.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®