From: Dan Carpenter <dan.carpenter@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
lkft-triage@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Subject: Re: next: arm64: defconfig: gcc-8: drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
Date: Fri, 12 Jul 2024 08:58:08 -0500 [thread overview]
Message-ID: <b833c93e-ae8f-449f-b7bd-8d315aa52703@suswa.mountain> (raw)
In-Reply-To: <CAMRc=Md5zmFxXXM89LQs6dspC0xnp_6=z=+a2SQypWjwpiRgow@mail.gmail.com>
On Fri, Jul 12, 2024 at 03:34:19AM -0500, Bartosz Golaszewski wrote:
> On Thu, 11 Jul 2024 16:34:35 +0200, Naresh Kamboju
> <naresh.kamboju@linaro.org> said:
> > The arm64 defconfig gcc-8 build failed [1] due to these warnings / errors on the
> > Linux next-20230711 tag. But the gcc-13 builds pass.
> >
> > LKFT is testing older toolchain support till gcc-8.
> >
> > The following recent changes cause this failure.
> > a887c8dede8e1 Bluetooth: hci_qca: schedule a devm action for disabling the clock
> >
> > Build errors with gcc-8:
> > -----------
> > drivers/bluetooth/hci_qca.c: In function 'qca_serdev_remove':
> > drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
> > default:
> > ^~~~~~~
> > make[5]: *** [scripts/Makefile.build:244: drivers/bluetooth/hci_qca.o]
> > Error 1a887c8dede8e1 Bluetooth: hci_qca: schedule a devm action for
> > disabling the clock
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Build data:
> > ------
> > * Build name: gcc-8-defconfig
> > * git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
> > * git_sha: f477dd6eede3ecedc8963478571d99ec3bf3f762
> > * git_short_log: f477dd6eede3 ("Add linux-next specific files for 20240711")
> > * Config: defconfig
> > * arch: arm64
> > * toolchain: gcc-8
> >
> > Steps to reproduce:
> > -------
> > # tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
> > --kconfig defconfig
> >
> > Build log links,
> > ---------------
> > [1] https://storage.tuxsuite.com/public/linaro/lkft/builds/2j5nr85T4iLl99RjcJ9oy9O3eo2/
> >
> > --
> > Linaro LKFT
> > https://lkft.linaro.org
> >
> >
>
> The actual code looks like this now:
>
> case QCA_WCN7850:
> if (power->vregs_on)
> qca_power_shutdown(&qcadev->serdev_hu);
> break;
> default:
>
> What can be done to silence this warning? Or should we just ignore it because
> it's gcc 8?
Just add a break statement.
default:
+ break;
}
regards,
dan carpenter
next prev parent reply other threads:[~2024-07-12 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 14:34 Naresh Kamboju
2024-07-12 8:34 ` Bartosz Golaszewski
2024-07-12 9:03 ` Arnd Bergmann
2024-07-12 9:09 ` Bartosz Golaszewski
2024-07-12 13:58 ` Dan Carpenter [this message]
2024-07-12 14:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b833c93e-ae8f-449f-b7bd-8d315aa52703@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=luiz.von.dentz@intel.com \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®