From: Scott Branden <scott.branden@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Olof Johansson <olof@lixom.net>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Desmond Yan <desmond.yan@broadcom.com>
Subject: Re: [PATCH v5 12/15] misc: bcm-vk: add sysfs interface
Date: Thu, 1 Oct 2020 15:17:06 -0700 [thread overview]
Message-ID: <b835d5a6-2ece-01c1-3911-050e06a1115f@broadcom.com> (raw)
In-Reply-To: <16725022-b967-deae-1223-f86a543f9f9d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4865 bytes --]
On 2020-09-30 7:30 p.m., Florian Fainelli wrote:
>
>
> On 9/30/2020 6:28 PM, Scott Branden wrote:
>> Add sysfs support to query the VK card status and monitor sense points.
>> The vk-card-status and vk-card-mon details are provided in the README
>> file in the bcm-vk driver directory.
>>
>> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>
> [snip]
>
>> +vk-card-status/
>> + bus ---> device PCIe bus
>> + card_state ---> summary of current card states
>> + chip_id
>> + firmware_status ---> summary of all firmware status
>> + firmware_version ---> summary of all firmware versions
>> + freq_core_mhz ---> running frequency in mHz
>> + freq_mem_mhz ---> memory frequency in mHz
>> + mem_size_mb ---> memory size in MByte
>> + os_state ---> current running state
>> + reset_reason ---> last reset reason
>> + rev_boot1 ---> boot1 firmware revision
>> + rev_boot2 ---> boot2 firmware revision
>> + rev_driver ---> host driver revision
>> + rev_flash_rom ---> Flash ROM revision
>> + sotp_boot1_rev_id ---> minimum boot1 revision required
>> + sotp_boot2_rev_id ---> minimum boot2 revision required
>> + sotp_dauth_1 ---> authentication key hash
>> + sotp_dauth_1_valid ---> authentication key validity
>> + sotp_dauth_1_active_status -> authentication key active or not
>> + sotp_dauth_2
>> + sotp_dauth_2_valid
>> + sotp_dauth_2_active_status
>> + sotp_dauth_3
>> + sotp_dauth_3_valid
>> + sotp_dauth_3_active_status
>> + sotp_dauth_4
>> + sotp_dauth_4_valid
>> + sotp_dauth_4_active_status
>> + temp_threshold_lower_c ---> thermal low threshold in Celsius
>> + temp_threshold_upper_c ---> thermal high threshold in Celsius
>> + uptime_s ---> os up time in seconds
>> +
>> +vk-card-mon/
>> + alert_afbc_busy ---> AFBC block stuck
>> + alert_ecc ---> uncorrectable ECC error(s) occurred
>> + alert_ecc_warn ---> correctable ECC error(s) occurred
>> + alert_heartbeat_fail ---> host detects heartbeat discontinuation
>> + from card
>> + alert_high_temp ---> high temperature threshold crossed
>> + alert_intf_ver_fail ---> interface not compatible based on version
>> + alert_low_temp_warn ---> low temperature threshold crossed
>> + alert_malloc_fail_warn ---> mem allocation failure(s) occurred
>> + alert_pcie_down ---> host detect pcie intf going down
>> + alert_ssim_busy ---> ssim block busy
>> + alert_sys_fault ---> system fault
>> + alert_wdog_timeout ---> watchdog timeout
>
> Almost all of these should be supported using the HWMON framework instead of custom attributes that do not follow the HWMON naming conventions.
Makes sense - we'll look at hwmon framework.
>
>> + firmware_status_reg
>> + mem_ecc ---> correctable ECC error count
>> + mem_uecc ---> uncorrectable ECC error count
>
> Implementing an EDAC driver would be a bit overkill unless you have a way to signal ECC errors towards the host?
Yes, EDAC driver would be overkill here.
>
>
>> + boot_status_reg ---> boot status of card
>> + pwr_state ---> power state, 1-full, 2-reduced, 3-lowest
>> + temperature_sensor_1_c ---> CPU die temperature in Celsius
>> + temperature_sensor_2_c ---> DDR0 temperature in Celsius
>> + temperature_sensor_3_c ---> DDR1 temperature in Celsius
>
> Likewise.
>
>> + utilization ---> runtime video transcoding consumption summary
>> + utilization_pix ---> percentage of pixel processing used
>> + utilization_pix_used ---> pixel processing used
>> + utilization_pix_max ---> max pixel processing value which maps 100% load
>> + utilization_codec ---> percentage of codec sessions used
>> + utilization_codec_used ---> codec sessions currently used
>> + utilization_codec_max ---> max codec sessions allowed
>> + voltage_18_mv ---> 1.8v voltage rail in mv
>> + voltage_33_mv ---> 3.3v voltage rail in mv
>
> Likewise
>
>> +
>> +The sysfs entry supports only the read operation.
>
> entries.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4169 bytes --]
next prev parent reply other threads:[~2020-10-01 22:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 1:27 [PATCH v5 00/15] Add Broadcom VK driver Scott Branden
2020-10-01 1:27 ` [PATCH v5 01/15] bcm-vk: add bcm_vk UAPI Scott Branden
2020-10-01 1:27 ` [PATCH v5 02/15] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-10-01 1:27 ` [PATCH v5 03/15] misc: bcm-vk: add autoload support Scott Branden
2020-10-01 4:07 ` kernel test robot
2020-10-01 17:48 ` Scott Branden
2020-10-02 5:36 ` [kbuild-all] " Philip Li
2020-10-01 1:27 ` [PATCH v5 04/15] misc: bcm-vk: add misc device to Broadcom VK driver Scott Branden
2020-10-01 1:28 ` [PATCH v5 05/15] misc: bcm-vk: add triggers when host panic or reboots to notify card Scott Branden
2020-10-01 1:28 ` [PATCH v5 06/15] misc: bcm-vk: add open/release Scott Branden
2020-10-01 1:28 ` [PATCH v5 07/15] misc: bcm-vk: add ioctl load_image Scott Branden
2020-10-01 1:28 ` [PATCH v5 08/15] misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_info Scott Branden
2020-10-01 1:28 ` [PATCH v5 09/15] misc: bcm-vk: add VK messaging support Scott Branden
2020-10-01 1:43 ` Joe Perches
2020-10-01 18:27 ` Scott Branden
2020-10-01 1:28 ` [PATCH v5 10/15] misc: bcm-vk: reset_pid support Scott Branden
2020-10-01 1:28 ` [PATCH v5 11/15] misc: bcm-vk: add BCM_VK_QSTATS Scott Branden
2020-10-01 2:33 ` Florian Fainelli
2020-10-01 22:12 ` Scott Branden
2020-10-01 22:13 ` Florian Fainelli
2020-10-02 16:54 ` Scott Branden
2020-10-02 4:55 ` Greg Kroah-Hartman
2020-10-02 16:52 ` Scott Branden
2020-10-01 1:28 ` [PATCH v5 12/15] misc: bcm-vk: add sysfs interface Scott Branden
2020-10-01 2:30 ` Florian Fainelli
2020-10-01 22:17 ` Scott Branden [this message]
2020-10-01 1:28 ` [PATCH v5 13/15] misc: bcm-vk: add mmap function for exposing BAR2 Scott Branden
2020-10-01 1:28 ` [PATCH v5 14/15] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-10-01 1:28 ` [PATCH v5 15/15] misc: bcm-vk: add ttyVK support Scott Branden
2020-10-01 2:36 ` Florian Fainelli
2020-10-01 22:26 ` Scott Branden
2020-10-01 2:38 ` [PATCH v5 00/15] Add Broadcom VK driver Florian Fainelli
2020-10-01 12:24 ` Olof Johansson
2020-10-01 22:34 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b835d5a6-2ece-01c1-3911-050e06a1115f@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=desmond.yan@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®