From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109F8C6369E for ; Thu, 19 Nov 2020 01:56:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2B0A246CA for ; Thu, 19 Nov 2020 01:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbgKSB4C (ORCPT ); Wed, 18 Nov 2020 20:56:02 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8111 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgKSB4B (ORCPT ); Wed, 18 Nov 2020 20:56:01 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cc2nl1fXzzLq1y; Thu, 19 Nov 2020 09:55:39 +0800 (CST) Received: from [127.0.0.1] (10.174.176.144) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Thu, 19 Nov 2020 09:55:51 +0800 Subject: Re: [PATCH 1/1] ACPI/nfit: correct the badrange to be reported in nfit_handle_mce() To: "Verma, Vishal L" , "linux-nvdimm@lists.01.org" , "Jiang, Dave" , "lenb@kernel.org" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "Williams, Dan J" , "linux-acpi@vger.kernel.org" , "Weiny, Ira" References: <20201118084117.1937-1-thunder.leizhen@huawei.com> <1fa493113c74a0618d34f0e5d88e4402abe3e69c.camel@intel.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Thu, 19 Nov 2020 09:55:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1fa493113c74a0618d34f0e5d88e4402abe3e69c.camel@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.144] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/19 4:50, Verma, Vishal L wrote: > On Wed, 2020-11-18 at 16:41 +0800, Zhen Lei wrote: >> The badrange to be reported should always cover mce->addr. >> >> Signed-off-by: Zhen Lei >> --- >> drivers/acpi/nfit/mce.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Ah good find, agreed with Dan that this is stable material. > Minor nit, I'd recommend rewording the subject line to something like: > > "acpi/nfit: fix badrange insertion in nfit_handle_mce()" OK, I will send v2. > > Otherwise, looks good to me. > Reviewed-by: Vishal Verma > >> >> diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c >> index ee8d9973f60b..053e719c7bea 100644 >> --- a/drivers/acpi/nfit/mce.c >> +++ b/drivers/acpi/nfit/mce.c >> @@ -63,7 +63,7 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val, >> >> /* If this fails due to an -ENOMEM, there is little we can do */ >> nvdimm_bus_add_badrange(acpi_desc->nvdimm_bus, >> - ALIGN(mce->addr, L1_CACHE_BYTES), >> + ALIGN_DOWN(mce->addr, L1_CACHE_BYTES), >> L1_CACHE_BYTES); >> nvdimm_region_notify(nfit_spa->nd_region, >> NVDIMM_REVALIDATE_POISON); >