From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>,
peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
Date: Fri, 19 Dec 2025 10:56:17 +0100 [thread overview]
Message-ID: <b83d45c4-eeea-4c0f-9395-6d6483c278f7@kernel.org> (raw)
In-Reply-To: <20251219095409.1395587-2-gary.yang@cixtech.com>
On 19/12/2025 10:54, Gary Yang wrote:
> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC,
> built-in 12-core 64-bit processor + NPU processor,
> integrated graphics processor, equipped with 16GB/32GB/64GB
> LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,
> as well as SPI FLASH and TF slots to meet the needs of fast
> read/write and high-capacity storage;
>
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> ---
> Documentation/devicetree/bindings/arm/cix.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml b/Documentation/devicetree/bindings/arm/cix.yaml
> index 114dab4bc4d2..92fb4ad7b5d8 100644
> --- a/Documentation/devicetree/bindings/arm/cix.yaml
> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
> @@ -21,6 +21,11 @@ properties:
> - const: radxa,orion-o6
> - const: cix,sky1
>
> + - description: OrangePi 6 Plus
> + items:
> + - const: OrangePi,6p
That's not a valid prefix. Where is it documented and how it looks there?
Why this cannot be part of enum with the first device? Creating a list
per device scales poorly.
> + - const: cix,sky1
> +
> additionalProperties: true
>
> ...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-19 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:54 [PATCH v1 0/2] Add " Gary Yang
2025-12-19 9:54 ` [PATCH v1 1/2] dt-bindings: arm: cix: add " Gary Yang
2025-12-19 9:56 ` Krzysztof Kozlowski [this message]
2025-12-19 9:54 ` [PATCH v1 2/2] arm64: dts: cix: Add OrangePi 6 Plus board support Gary Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b83d45c4-eeea-4c0f-9395-6d6483c278f7@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cix-kernel-upstream@cixtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®