From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966894AbdAHVuN (ORCPT ); Sun, 8 Jan 2017 16:50:13 -0500 Received: from mout.web.de ([212.227.15.3]:59152 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966327AbdAHVto (ORCPT ); Sun, 8 Jan 2017 16:49:44 -0500 Subject: [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions To: linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Shawn Lin , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sun, 8 Jan 2017 22:49:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Q2YycDG3MgSKP81PNH/3/Wcc2jAo17oq1BWbK1NQ9dSlXQvFiRo 1vPkqF/Kuqn4pZDfWiYUhiwlwhyBEz8fUn4sk/LveiLzhg+epdtw39JwhViTJh1r/u7DtNd ZBYLdYn9lJdMRT3Y2KGpqaw9X1Iye9BwX19CTIzcODh0TtG6mvBwfIiuyuhwQgXOGpHVRnw NnG+6BvXVze71DcmGEDEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:lVRK2WJHxcQ=:S0Le7+DlsK0kkO//nV3GZj vB2SZl0u8OzytRlvS4h93dcdyl/S4pkKe3TZ/Uoj+ubbsYYfws80VmLY9rLxAFtVACL+sv7kD uSS5vi+oKzUPVtERFJEhbsCG+UkYU7KPndUxsIDCUUeAS30ZbvBs+lzDzVwpHM1BsYfORvpPD MHAyap9f6yUEtHb50PO0hHDk8U4Pa6hK1PYq8ViRUM+0SvPzP5yv/1wJXp4Fv7j1xrccZj0J5 vkikp60XbjKKIteayq2yNDllCyi5xOyU6jk3DqsS4XfSVCY1VgFXWT5TjqOe5l0trlbdI0jbG y0FiGGBWFY/k1/dx1hVSolm2atO4MaDp+lFNan2H2K0wZumDRvL5xzgAws5ZzPu5brGQa3YuV Rsv99C8FVsQUz7N15lXxWiD4l9OVBrjduz5Ap/38ldzBTDl6OWsAXmSFirHrk7cqXauc6zeHy xXxDRcvJe1fnA4CCrxaSCSo2T5uxTWGa+wSP7aK+WZeNTAJfqTKxSLrpYWgAgytn5vIBYp1Vx CmpMWz7TJ+fkrkS/YfRqh+Ay2tMyoQnjrHPlbuUs+CwqFvOBVduGE5gcBXuO3wa1edCKmGvXe PLca5uTDBLY+/DXYOG5aqUlXeJZTzpd9y018RUSqOT3TQYRZJm9cHkjAK+cmWTqk9Iyi1D93/ mUOher04naSVwGsSma6RDOJXVwyWSZG2RzxwSxhz0S1bwpWdglWwPQMAZbwXO0knrc54TMCFC ZqpWnLlKaJwOxF2nYHBscZdIp358136aTzxh2iCOLpuoYdA2NWiHRJIwQ+gTJtfa/3ZmWRbf5 xnw09KW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 8 Jan 2017 21:25:44 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mmc/core/mmc_test.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c index bb9f569a5dd5..294d3c675734 100644 --- a/drivers/mmc/core/mmc_test.c +++ b/drivers/mmc/core/mmc_test.c @@ -356,7 +356,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, if (max_segs > max_page_cnt) max_segs = max_page_cnt; - mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL); + mem = kzalloc(sizeof(*mem), GFP_KERNEL); if (!mem) return NULL; @@ -545,7 +545,7 @@ static void mmc_test_save_transfer_result(struct mmc_test_card *test, if (!test->gr) return; - tr = kmalloc(sizeof(struct mmc_test_transfer_result), GFP_KERNEL); + tr = kmalloc(sizeof(*tr), GFP_KERNEL); if (!tr) return; @@ -2973,8 +2973,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) } } - gr = kzalloc(sizeof(struct mmc_test_general_result), - GFP_KERNEL); + gr = kzalloc(sizeof(*gr), GFP_KERNEL); if (gr) { INIT_LIST_HEAD(&gr->tr_lst); @@ -3108,7 +3107,7 @@ static ssize_t mtf_test_write(struct file *file, const char __user *buf, if (ret) return ret; - test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); + test = kzalloc(sizeof(*test), GFP_KERNEL); if (!test) return -ENOMEM; @@ -3213,7 +3212,7 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card, return -ENODEV; } - df = kmalloc(sizeof(struct mmc_test_dbgfs_file), GFP_KERNEL); + df = kmalloc(sizeof(*df), GFP_KERNEL); if (!df) { debugfs_remove(file); dev_err(&card->dev, -- 2.11.0