mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mathew McBride" <matt@traverse.com.au>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
	"Mark Tomlinson" <mark.tomlinson@alliedtelesis.co.nz>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors
Date: Tue, 08 Aug 2023 17:54:41 +1000	[thread overview]
Message-ID: <b84c2fba-1bbe-4842-a861-525784d8a361@app.fastmail.com> (raw)
In-Reply-To: <0248d597-b72a-5b7c-63a4-6d72384f9854@kernel.org>

Hi Krzysztof,

On Tue, Aug 8, 2023, at 5:38 PM, Krzysztof Kozlowski wrote:
> On 08/08/2023 03:31, Mark Tomlinson wrote:
> > This patch adds a HWMON driver for the EMC1812, EMC1813, EMC1814,
> > EMC1815 and EMC1833 temperature sensor chips from microchip. Does not
> > currently support the alert outputs.
> > 
> > Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> > Co-developed-by: Mathew McBride <matt@traverse.com.au>
> > Signed-off-by: Mathew McBride <matt@traverse.com.au>
> 
> The order of these tags is clearly not correct. It says Mathew is
> sending, but you are not Mathew?

Just to clarify, Mark has developed this version based off something I wrote a while ago:

https://gitlab.com/traversetech/ls1088firmware/traverse-sensors/-/blob/master/emc181x/emc181x.c?ref_type=heads

Hence my copyright is listed in the header.

I advised him to list the authors in that order following the example in the kernel's "submitting patches" guide [2] which provides an example of such a situation:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

If I interpreted the guidelines incorrectly, happy to be corrected.

Best Regards,
Matt

  reply	other threads:[~2023-08-08 15:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  1:31 Mark Tomlinson
2023-08-08  1:31 ` [PATCH 2/2] dt-bindings: hwmon: add EMC181x Mark Tomlinson
2023-08-08  3:54   ` Guenter Roeck
2023-08-08  7:35   ` Krzysztof Kozlowski
2023-08-08  4:24 ` [PATCH 1/2] hwmon: Add driver for EMC181x temperature sensors Guenter Roeck
2023-08-08  7:38 ` Krzysztof Kozlowski
2023-08-08  7:54   ` Mathew McBride [this message]
2023-08-08  8:10     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b84c2fba-1bbe-4842-a861-525784d8a361@app.fastmail.com \
    --to=matt@traverse.com.au \
    --cc=jdelvare@suse.com \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.tomlinson@alliedtelesis.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®