mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Umang Chheda <umang.chheda@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	richardcochran@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, mohd.anwar@oss.qualcomm.com,
	krishna.chundru@oss.qualcomm.com,
	monish.chunara@oss.qualcomm.com
Subject: Re: [PATCH 1/1] arm64: dts: qcom: lemans-evk: Add Mezzanine
Date: Tue, 3 Feb 2026 01:01:08 +0530	[thread overview]
Message-ID: <b851075c-0ec5-46f6-9da0-a9f814d04005@oss.qualcomm.com> (raw)
In-Reply-To: <27c91542-820e-49bd-870a-d492be21958a@oss.qualcomm.com>

Hello Konrad,

On 1/30/2026 4:21 PM, Konrad Dybcio wrote:
> On 1/29/26 6:28 PM, Umang Chheda wrote:
>> The Mezzanine is an hardware expansion add-on board designed
>> to be stacked on top of Lemans EVK.
>>
>> It has following peripherals :
>>
>> - 4x Type A USB ports in host mode.
>> - TC9563 PCIe switch, which has following three downstream ports (DSP) :
>>    - 1st DSP connects M.2 E-key connector for connecting WLAN endpoints.
>>    - 2nd DSP connects M.2 B-key connector for connecting cellular modems.
>>    - 3rd DSP with support for Dual Ethernet ports.
>> - eMMC.
>> - Additional 2.5GbE Ethernet PHY connected to native EMAC with support for
>>   MAC Address configuration via NVMEM.
>> - EEPROM.
>> - LVDS Display.
>> - 2*mini DP.
>>
>> Add support for following peripherals :
>> - TC9563 PCIe Switch.
>> - Additional 2.5GbE Ethernet Port.
>> - EEPROM.
>>
>> Written with inputs from :
>>     Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> - Ethernet.
>>     Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> - PCIe
>>     Monish Chunara <monish.chunara@oss.qualcomm.com> - EEPROM.
>>
>> Signed-off-by: Umang Chheda <umang.chheda@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile             |   4 +
>>  .../boot/dts/qcom/lemans-evk-mezzanine.dtso   | 301 ++++++++++++++++++
>>  2 files changed, 305 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/qcom/lemans-evk-mezzanine.dtso
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index f80b5d9cf1e8..79449004adfd 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -43,6 +43,10 @@ dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk-camera.dtb
>>  lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo
>>
>>  dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk-el2.dtb
>> +
>> +lemans-evk-mezzanine-dtbs	:= lemans-evk.dtb lemans-evk-mezzanine.dtbo
>> +
>> +dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk-mezzanine.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= milos-fairphone-fp6.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= monaco-evk.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= msm8216-samsung-fortuna3g.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-mezzanine.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-mezzanine.dtso
>> new file mode 100644
>> index 000000000000..a0dc6daec754
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-mezzanine.dtso
>> @@ -0,0 +1,301 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +&{/} {
>> +	model = "Qualcomm Technologies, Inc. Lemans-evk Mezzanine";
>> +
>> +	vreg_sys_pwr: regulator-vreg-sys-pwr {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "VREG_SYS_PWR";
>> +
>> +		regulator-always-on;
>> +		regulator-boot-on;
> nit: usually we put these at the end
Ack
>
> [...]
>
>> +&tlmm {
>> +	ethernet1_default: ethernet1-default-state {
>> +		ethernet1_mdc: ethernet1-mdc-pins {
> You can drop the labels for these inner entries, as you never
> reference them

Ack

>
> Konrad

Thanks,
Umang


  reply	other threads:[~2026-02-02 19:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 17:28 [PATCH 0/1] Introduce Lemans EVK Peripheral Mezzanine Umang Chheda
2026-01-29 17:28 ` [PATCH 1/1] arm64: dts: qcom: lemans-evk: Add Mezzanine Umang Chheda
2026-01-30 10:51   ` Konrad Dybcio
2026-02-02 19:31     ` Umang Chheda [this message]
2026-01-30 10:53   ` Konrad Dybcio
2026-01-30 20:11     ` Andrew Lunn
2026-02-02 10:17       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b851075c-0ec5-46f6-9da0-a9f814d04005@oss.qualcomm.com \
    --to=umang.chheda@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohd.anwar@oss.qualcomm.com \
    --cc=monish.chunara@oss.qualcomm.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®