From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B8CC433F5 for ; Mon, 25 Apr 2022 09:38:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240475AbiDYJlP (ORCPT ); Mon, 25 Apr 2022 05:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240617AbiDYJkW (ORCPT ); Mon, 25 Apr 2022 05:40:22 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F4B91A83E for ; Mon, 25 Apr 2022 02:36:44 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id r13so28463687ejd.5 for ; Mon, 25 Apr 2022 02:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nuXvyXcfSlNNf+vXWbc6QlS7EMXyhZacegPBGO4WZEs=; b=LofUgeVi0Jw8/ef3AsJTGrYnJHHHe49mIAEj8U+4jh9GWrmr/JEr5K7s/JaE8pkdQc ldRehpBumgnOkWBH4HoP8RjF+mPFQpXTivbJnAz9/ZJwXzYxWLHVq4/zv+1TsqZDUCPe FUXh0c/rJ/FXHYflHmrvIQ28U9mNJBVGoaWw8ilrRcVg/tCBYOQygMV9WKM8aXhiU+CK ki881ebBGEDLu2hGbI4fbe0Y8HF2SSK6SELRQpD/zj9nyG52zCCdzhftcw10L9DzMVGL qwuMBdmqeraSZ/X6F2VltV8ys4qFqSzWMRZF303+fBMNDJ6deaBlyEr+q3xOMoJdlt5d Lacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nuXvyXcfSlNNf+vXWbc6QlS7EMXyhZacegPBGO4WZEs=; b=dGWrTVuRykqy4KLPyFYUx1xNDEMdv4U1TWDsRGJ52p8a2p5FJgzio7QzCpjIChez9F R3vJesv1QyyZFeoIJkFTfNGgX6yaHlO36MmeR1hmAmqCMkV6SMcJC9bVC6k4tNvj1olK m+yBaz0+iTBif9KzU1P2oD+EOuYsKoPc/cjLC9BSFKNY2z2pIltTSr72LZ+/fiS7GIVU c+WQswD2C38e68zanPjA847M4xX0CJBaHmz/NTe2wL4nxd95nZw2K2Fw53CxHIaXCcEk hGNFA1rX0ifYzFeXETWMeA0sYea0/WVL+k9VokX38PhifPz7DX8Vo2F3aww7wjTPKRrb 8b8A== X-Gm-Message-State: AOAM533+WKQzDBF0JDBZw5cZ0QcoEvHcu3Yd3jNqPpRyzgXvHkzXwz+s RUPV08yMsOqdWPa1lB1BuJQqTQ== X-Google-Smtp-Source: ABdhPJzwCPLJ4SHeT4lNCV0T5wY9lLZjkgpo2vprKwldO/cFdtJ3tXRPuO09NOtQsRvHlnNH7XK6AQ== X-Received: by 2002:a17:906:3104:b0:6ce:6b85:ecc9 with SMTP id 4-20020a170906310400b006ce6b85ecc9mr15154977ejx.339.1650879403173; Mon, 25 Apr 2022 02:36:43 -0700 (PDT) Received: from [192.168.0.241] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id ak18-20020a170906889200b006f39a445b93sm694706ejc.141.2022.04.25.02.36.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 02:36:42 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 11:36:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: nvmem: mediatek: Convert binding to YAML Content-Language: en-US To: Allen-KH Cheng , Srinivas Kandagatla , Matthias Brugger , Rob Herring , Krzysztof Kozlowski Cc: Lala Lin , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee References: <20220422123823.24577-1-allen-kh.cheng@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220422123823.24577-1-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/2022 14:38, Allen-KH Cheng wrote: > Convert Mediatek EFUSE devicetree binding to YAML. > > Signed-off-by: Allen-KH Cheng > --- > .../devicetree/bindings/nvmem/mtk-efuse.txt | 43 ------------ > .../devicetree/bindings/nvmem/mtk-efuse.yaml | 69 +++++++++++++++++++ Same comments as usual, so "vendor,device-name", e.g. "mediatek,efuse" if this is going to match all possible future MediaTek chips or "mediatek,mt7622-efuse" Folks in MediaTek: it would be useful if we did not have to repeat same review to all of you for every patch. If you keep forcing the reviewers to repeat the same and the same, eventually they become grumpier and grumpier. :) > 2 files changed, 69 insertions(+), 43 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > create mode 100644 Documentation/devicetree/bindings/nvmem/mtk-efuse.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > deleted file mode 100644 > index 39d529599444..000000000000 > --- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt > +++ /dev/null > @@ -1,43 +0,0 @@ > -= Mediatek MTK-EFUSE device tree bindings = > - > -This binding is intended to represent MTK-EFUSE which is found in most Mediatek SOCs. > - > -Required properties: > -- compatible: should be > - "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622 > - "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623 > - "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173 > - "mediatek,mt8192-efuse", "mediatek,efuse": for MT8192 > - "mediatek,mt8195-efuse", "mediatek,efuse": for MT8195 > - "mediatek,mt8516-efuse", "mediatek,efuse": for MT8516 > -- reg: Should contain registers location and length > -- bits: contain the bits range by offset and size > - > -= Data cells = > -Are child nodes of MTK-EFUSE, bindings of which as described in > -bindings/nvmem/nvmem.txt > - > -Example: > - > - efuse: efuse@10206000 { > - compatible = "mediatek,mt8173-efuse"; > - reg = <0 0x10206000 0 0x1000>; > - #address-cells = <1>; > - #size-cells = <1>; > - > - /* Data cells */ > - thermal_calibration: calib@528 { > - reg = <0x528 0xc>; > - }; > - }; > - > -= Data consumers = > -Are device nodes which consume nvmem data cells. > - > -For example: > - > - thermal { > - ... > - nvmem-cells = <&thermal_calibration>; > - nvmem-cell-names = "calibration"; > - }; > diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.yaml b/Documentation/devicetree/bindings/nvmem/mtk-efuse.yaml > new file mode 100644 > index 000000000000..307c05f69cb9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/mtk-efuse.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek eFuse device tree bindings s/device tree bindings// Folks in MediaTek: it would be useful if we did not have to repeat same review to all of you for every patch. > + > +maintainers: > + - Lala Lin > + - Allen-KH Cheng > + > +allOf: > + - $ref: "nvmem.yaml#" > + > +properties: > + compatible: > + oneOf: > + - const: mediatek,efuse 1. Please add a comment for which compatible this is valid. Such generic compatibles should not be used standalone. The binding was accepted (without DT review), so it's done, but let's not spread it over new DTS. Actually I would prefer to deprecate it in second patch. 2. Same comments as usual - this is enum. Folks in MediaTek: it would be useful if we did not have to repeat same review to all of you for every patch. > + - const: mediatek,mt8173-efuse > + - items: > + - enum: > + - mediatek,mt7622-efuse > + - mediatek,mt7623-efuse > + - mediatek,mt8183-efuse > + - mediatek,mt8192-efuse > + - mediatek,mt8195-efuse > + - mediatek,mt8516-efuse > + - const: mediatek,efuse > + > + reg: > + maxItems: 1 > + > +patternProperties: > + "^.*@[0-9a-f]+$": > + type: object No need, it comes from nvmem.yaml. > + > + properties: > + reg: > + maxItems: 1 > + description: > + Offset and size in bytes within the storage device. > + > + required: > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + Unneeded blank line. > + efuse: efuse@10206000 { > + compatible = "mediatek,mt8173-efuse"; > + reg = <0x10206000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + /* Data cells */ > + thermal_calibration: calib@528 { > + reg = <0x528 0xc>; > + }; > + }; > +... Best regards, Krzysztof