From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: miklos@szeredi.hu, vgoyal@redhat.com, linux-fsdevel@vger.kernel.org
Cc: gerry@linux.alibaba.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: fix return value of inode_inline_reclaim_one_dmap in error path
Date: Wed, 17 May 2023 08:07:54 +0800 [thread overview]
Message-ID: <b8549484-5385-0410-c849-4d0c591574f9@linux.alibaba.com> (raw)
In-Reply-To: <20230424123250.125404-1-jefflexu@linux.alibaba.com>
ping...
On 4/24/23 8:32 PM, Jingbo Xu wrote:
> When range already got reclaimed by somebody else, return NULL so that
> the caller could retry to allocate or reclaim another range, instead of
> mistakenly returning the range already got reclaimed and reused by
> others.
>
> Reported-by: Liu Jiang <gerry@linux.alibaba.com>
> Fixes: 9a752d18c85a ("virtiofs: add logic to free up a memory range")
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> ---
> fs/fuse/dax.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> index 8e74f278a3f6..59aadfd89ee5 100644
> --- a/fs/fuse/dax.c
> +++ b/fs/fuse/dax.c
> @@ -985,6 +985,7 @@ inode_inline_reclaim_one_dmap(struct fuse_conn_dax *fcd, struct inode *inode,
> node = interval_tree_iter_first(&fi->dax->tree, start_idx, start_idx);
> /* Range already got reclaimed by somebody else */
> if (!node) {
> + dmap = NULL;
> if (retry)
> *retry = true;
> goto out_write_dmap_sem;
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-05-17 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:32 Jingbo Xu
2023-05-17 0:07 ` Jingbo Xu [this message]
[not found] ` <ZHeoIFrp303f0E8d@redhat.com>
2023-06-01 1:45 ` Jingbo Xu
2023-06-01 11:45 ` Vivek Goyal
2023-06-02 2:01 ` Jingbo Xu
2023-06-20 3:50 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8549484-5385-0410-c849-4d0c591574f9@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=gerry@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®