From: Xi Ruoyao <xry111@xry111.site>
To: "WANG Xuerui" <kernel@xen0n.name>, 关文涛 <guanwentao@uniontech.com>,
王昱力 <wangyuli@uniontech.com>,
herbert <herbert@gondor.apana.org.au>,
davem <davem@davemloft.net>, chenhuacai <chenhuacai@kernel.org>
Cc: linux-crypto <linux-crypto@vger.kernel.org>,
loongarch <loongarch@lists.linux.dev>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations
Date: Tue, 27 Feb 2024 17:22:18 +0800 [thread overview]
Message-ID: <b858ec2a84546d7cdb666fd01c44a23714a33332.camel@xry111.site> (raw)
In-Reply-To: <0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name>
On Tue, 2024-02-27 at 15:42 +0800, WANG Xuerui wrote:
> Sorry. I have checked the manual and it turns out you & Yuli are
> correct: even though the narrower CRC instructions doesn't require
> GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual
> v1.10, Volume 1, Table 2-1). Counter-intuitive as it is, the original
> patch is correct nevertheless.
But I don't think the table in the spec will 100% reflect the real
status of the LA32 hardware. And we should use CPUCFG to detect it
anyway.
Based on my experience programming some aeronautic device I'd say having
some hardware CRC support should be useful even in embedded area.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2024-02-27 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:03 WangYuli
2024-02-26 8:15 ` WANG Xuerui
2024-02-26 8:25 ` 关文涛
2024-02-27 7:42 ` WANG Xuerui
2024-02-27 9:22 ` Xi Ruoyao [this message]
2024-02-27 7:52 ` WANG Xuerui
2024-02-27 8:44 ` 关文涛
2024-02-27 9:14 ` 王昱力
2024-02-29 3:05 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b858ec2a84546d7cdb666fd01c44a23714a33332.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=guanwentao@uniontech.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@xen0n.name \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=wangyuli@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®