From: Bhavya Kapoor <b-kapoor@ti.com>
To: Judith Mendez <jm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values
Date: Tue, 8 Oct 2024 16:42:01 +0530 [thread overview]
Message-ID: <b8598c92-b511-4e83-ac21-717ffc915d31@ti.com> (raw)
In-Reply-To: <20240924195335.546900-1-jm@ti.com>
Looks good to me !
On 25/09/24 01:23, Judith Mendez wrote:
> Update itap/itap values according to device datasheet [0].
>
> Now that we have fixed timing issues for am62x [1], lets
> change the otap/itap values back according to the device
> datasheet.
>
> [0] https://www.ti.com/lit/ds/symlink/am625.pdf
> [1] https://lore.kernel.org/linux-mmc/20240913185403.1339115-1-jm@ti.com/
>
> Signed-off-by: Judith Mendez <jm@ti.com>
Reviewed-by: Bhavya Kapoor<b-kapoor@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 47 ++++++++++++------------
> 1 file changed, 23 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 5b92aef5b284..7194603fd3bc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -561,10 +561,9 @@ sdhci0: mmc@fa10000 {
> ti,clkbuf-sel = <0x7>;
> ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-mmc-hs = <0x0>;
> - ti,otap-del-sel-ddr52 = <0x5>;
> - ti,otap-del-sel-hs200 = <0x5>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-mmc-hs = <0x1>;
> + ti,otap-del-sel-hs200 = <0x6>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-mmc-hs = <0x0>;
> status = "disabled";
> };
>
> @@ -577,17 +576,17 @@ sdhci1: mmc@fa00000 {
> clock-names = "clk_ahb", "clk_xin";
> bus-width = <4>;
> ti,clkbuf-sel = <0x7>;
> - ti,otap-del-sel-legacy = <0x8>;
> + ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-sd-hs = <0x0>;
> - ti,otap-del-sel-sdr12 = <0x0>;
> - ti,otap-del-sel-sdr25 = <0x0>;
> - ti,otap-del-sel-sdr50 = <0x8>;
> - ti,otap-del-sel-sdr104 = <0x7>;
> - ti,otap-del-sel-ddr50 = <0x4>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-sd-hs = <0x1>;
> - ti,itap-del-sel-sdr12 = <0xa>;
> - ti,itap-del-sel-sdr25 = <0x1>;
> + ti,otap-del-sel-sdr12 = <0xf>;
> + ti,otap-del-sel-sdr25 = <0xf>;
> + ti,otap-del-sel-sdr50 = <0xc>;
> + ti,otap-del-sel-sdr104 = <0x6>;
> + ti,otap-del-sel-ddr50 = <0x9>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-sd-hs = <0x0>;
> + ti,itap-del-sel-sdr12 = <0x0>;
> + ti,itap-del-sel-sdr25 = <0x0>;
> status = "disabled";
> };
>
> @@ -600,17 +599,17 @@ sdhci2: mmc@fa20000 {
> clock-names = "clk_ahb", "clk_xin";
> bus-width = <4>;
> ti,clkbuf-sel = <0x7>;
> - ti,otap-del-sel-legacy = <0x8>;
> + ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-sd-hs = <0x0>;
> - ti,otap-del-sel-sdr12 = <0x0>;
> - ti,otap-del-sel-sdr25 = <0x0>;
> - ti,otap-del-sel-sdr50 = <0x8>;
> - ti,otap-del-sel-sdr104 = <0x7>;
> - ti,otap-del-sel-ddr50 = <0x8>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-sd-hs = <0xa>;
> - ti,itap-del-sel-sdr12 = <0xa>;
> - ti,itap-del-sel-sdr25 = <0x1>;
> + ti,otap-del-sel-sdr12 = <0xf>;
> + ti,otap-del-sel-sdr25 = <0xf>;
> + ti,otap-del-sel-sdr50 = <0xc>;
> + ti,otap-del-sel-sdr104 = <0x6>;
> + ti,otap-del-sel-ddr50 = <0x9>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-sd-hs = <0x0>;
> + ti,itap-del-sel-sdr12 = <0x0>;
> + ti,itap-del-sel-sdr25 = <0x0>;
> status = "disabled";
> };
>
next prev parent reply other threads:[~2024-10-08 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 19:53 Judith Mendez
2024-10-08 11:12 ` Bhavya Kapoor [this message]
2024-10-30 4:50 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8598c92-b511-4e83-ac21-717ffc915d31@ti.com \
--to=b-kapoor@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®