mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@openvpn.net>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Shuah Khan <shuah@kernel.org>,
	sd@queasysnail.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v11 05/23] ovpn: keep carrier always on
Date: Mon, 2 Dec 2024 11:40:31 +0100	[thread overview]
Message-ID: <b868dcf1-7c0d-4511-8016-89302e7cb9c4@openvpn.net> (raw)
In-Reply-To: <55d91682-762e-411e-8abc-0790a9d81102@openvpn.net>

On 26/11/2024 09:17, Antonio Quartulli wrote:
[...]
>> It wasn't suggested to destroy the interface in case of interface 
>> becoming non-operational. I apologize if something I wrote earlier 
>> sounded like that. The interface existence stays unquestionable. It's 
>> going to be solid persistent.
>>
>> Back to the proposed rephrasing. If the 'full picture' means forcing 
>> the running state indication even when the netdev is not capable to 
>> deliver packets, then it looks like an attempt to hide the control 
>> knob of the misguiding feature somewhere else.
>>
>> And since the concept of on-purpose false indication is still here, 
>> many words regarding the control plane and a full picture do not sound 
>> good either.
> 

Sergey,

I have played a bit with this and, if I understood your idea correctly, 
the following should be an acceptable design for a P2P interface:

* iface created -> netif_carrier_off
* peer added -> netif_carrier_on
* peer deleted -> netif_carrier_off
* iface goes down -> peer deleted -> netif_carrier_off
* iface goes up -> carrier stays down until peer is added


P2MP interface behaviour is not changed: when interface is brought up 
carrier goes on and it is never turned off.

How does it sound?

My main concern was about bringing the interface down, but this is 
actually not happening. Correct me if I am wrong.

Thanks.

Regards,


-- 
Antonio Quartulli
OpenVPN Inc.


  reply	other threads:[~2024-12-02 10:39 UTC|newest]

Thread overview: 158+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 10:47 [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 01/23] netlink: add NLA_POLICY_MAX_LEN macro Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 02/23] net: introduce OpenVPN Data Channel Offload (ovpn) Antonio Quartulli
2024-11-06  0:31   ` Sergey Ryazanov
2024-11-15  9:56     ` Antonio Quartulli
2024-11-19  1:49       ` Sergey Ryazanov
2024-10-29 10:47 ` [PATCH net-next v11 03/23] ovpn: add basic netlink support Antonio Quartulli
2024-11-08 23:15   ` Sergey Ryazanov
2024-11-15 10:05     ` Antonio Quartulli
2024-11-19  2:05       ` Sergey Ryazanov
2024-11-19  8:12         ` Antonio Quartulli
2024-11-08 23:31   ` Sergey Ryazanov
2024-11-15 10:19     ` Antonio Quartulli
2024-11-19  2:23       ` Sergey Ryazanov
2024-11-19  8:16         ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 04/23] ovpn: add basic interface creation/destruction/management routines Antonio Quartulli
2024-11-09  1:01   ` Sergey Ryazanov
2024-11-12 16:47     ` Sabrina Dubroca
2024-11-12 23:56       ` Sergey Ryazanov
2024-11-14  8:07       ` Antonio Quartulli
2024-11-14 22:57         ` Sergey Ryazanov
2024-11-15 13:45           ` Antonio Quartulli
2024-11-15 13:00     ` Antonio Quartulli
2024-11-10 20:42   ` Sergey Ryazanov
2024-11-15 14:03     ` Antonio Quartulli
2024-11-19  3:08       ` Sergey Ryazanov
2024-11-19  8:45         ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 05/23] ovpn: keep carrier always on Antonio Quartulli
2024-11-09  1:11   ` Sergey Ryazanov
2024-11-15 14:13     ` Antonio Quartulli
2024-11-20 22:56       ` Sergey Ryazanov
2024-11-21 21:17         ` Antonio Quartulli
2024-11-23 22:25           ` Sergey Ryazanov
2024-11-23 22:52             ` Antonio Quartulli
2024-11-25  2:26               ` Sergey Ryazanov
2024-11-25 13:07                 ` Antonio Quartulli
2024-11-25 21:32                   ` Sergey Ryazanov
2024-11-26  8:17                     ` Antonio Quartulli
2024-12-02 10:40                       ` Antonio Quartulli [this message]
2024-10-29 10:47 ` [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object Antonio Quartulli
2024-10-30 16:37   ` Sabrina Dubroca
2024-10-30 20:47     ` Antonio Quartulli
2024-11-05 13:12       ` Sabrina Dubroca
2024-11-12 10:12         ` Antonio Quartulli
2024-11-10 13:38   ` Sergey Ryazanov
2024-11-12 17:31     ` Sabrina Dubroca
2024-11-13  1:37       ` Sergey Ryazanov
2024-11-13 10:03         ` Sabrina Dubroca
2024-11-20 23:22           ` Sergey Ryazanov
2024-11-21 21:23             ` Antonio Quartulli
2024-11-23 21:05               ` Sergey Ryazanov
2024-11-10 19:52   ` Sergey Ryazanov
2024-11-14 14:55     ` Antonio Quartulli
2024-11-20 11:56   ` Sabrina Dubroca
2024-11-21 21:27     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 07/23] ovpn: introduce the ovpn_socket object Antonio Quartulli
2024-11-10 18:26   ` Sergey Ryazanov
2024-11-15 14:28     ` Antonio Quartulli
2024-11-19 13:44       ` Antonio Quartulli
2024-11-20 23:34         ` Sergey Ryazanov
2024-11-21 21:29           ` Antonio Quartulli
2024-11-20 23:58       ` Sergey Ryazanov
2024-11-21 21:36         ` Antonio Quartulli
2024-11-22  8:08           ` Sergey Ryazanov
2024-10-29 10:47 ` [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP) Antonio Quartulli
2024-10-30 17:14   ` Sabrina Dubroca
2024-10-30 20:58     ` Antonio Quartulli
2024-11-10 22:32   ` Sergey Ryazanov
2024-11-12 17:28     ` Sabrina Dubroca
2024-11-14 15:25     ` Antonio Quartulli
2024-11-10 23:54   ` Sergey Ryazanov
2024-11-15 14:39     ` Antonio Quartulli
2024-11-21  0:29       ` Sergey Ryazanov
2024-11-21 21:39         ` Antonio Quartulli
2024-11-20 11:45   ` Sabrina Dubroca
2024-11-21 21:41     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 09/23] ovpn: implement basic RX " Antonio Quartulli
2024-10-31 11:29   ` Sabrina Dubroca
2024-10-31 13:04     ` Antonio Quartulli
2024-11-11  1:54   ` Sergey Ryazanov
2024-11-15 15:02     ` Antonio Quartulli
2024-11-26  0:32       ` Sergey Ryazanov
2024-11-26  8:49         ` Antonio Quartulli
2024-11-27  1:40           ` Antonio Quartulli
2024-11-29 13:20             ` Sabrina Dubroca
2024-12-01 23:34               ` Antonio Quartulli
2024-11-29 16:10         ` Sabrina Dubroca
2024-12-01 23:39           ` Antonio Quartulli
2024-12-02  3:53           ` Antonio Quartulli
2024-11-12  0:16   ` Sergey Ryazanov
2024-11-15 15:05     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 10/23] ovpn: implement packet processing Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 11/23] ovpn: store tunnel and transport statistics Antonio Quartulli
2024-10-31 11:37   ` Sabrina Dubroca
2024-10-31 13:12     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 12/23] ovpn: implement TCP transport Antonio Quartulli
2024-10-31 14:30   ` Antonio Quartulli
2024-10-31 15:25   ` Sabrina Dubroca
2024-11-16  0:33     ` Antonio Quartulli
2024-11-26  1:05       ` Sergey Ryazanov
2024-11-26  8:51         ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 13/23] ovpn: implement multi-peer support Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 14/23] ovpn: implement peer lookup logic Antonio Quartulli
2024-11-04 11:26   ` Sabrina Dubroca
2024-11-12  1:18     ` Sergey Ryazanov
2024-11-12 12:32       ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 15/23] ovpn: implement keepalive mechanism Antonio Quartulli
2024-11-05 18:10   ` Sabrina Dubroca
2024-11-12 13:20     ` Antonio Quartulli
2024-11-13 10:36       ` Sabrina Dubroca
2024-11-14  8:12         ` Antonio Quartulli
2024-11-14  9:03           ` Sabrina Dubroca
2024-11-22  9:41       ` Antonio Quartulli
2024-11-22 16:18         ` Sabrina Dubroca
2024-11-24  0:28           ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 16/23] ovpn: add support for updating local UDP endpoint Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 17/23] ovpn: add support for peer floating Antonio Quartulli
2024-11-04 11:24   ` Sabrina Dubroca
2024-11-12 13:52     ` Antonio Quartulli
2024-11-12 10:56   ` Sabrina Dubroca
2024-11-12 14:03     ` Antonio Quartulli
2024-11-13 11:25       ` Sabrina Dubroca
2024-11-14  8:26         ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink Antonio Quartulli
2024-11-04 15:14   ` Sabrina Dubroca
2024-11-12 14:19     ` Antonio Quartulli
2024-11-13 16:56       ` Sabrina Dubroca
2024-11-14  9:21         ` Antonio Quartulli
2024-11-20 11:12           ` Sabrina Dubroca
2024-11-20 11:34             ` Antonio Quartulli
2024-11-20 12:10               ` Sabrina Dubroca
2024-11-11 15:41   ` Sabrina Dubroca
2024-11-12 14:26     ` Antonio Quartulli
2024-11-13 11:05       ` Sabrina Dubroca
2024-11-14 10:32         ` Antonio Quartulli
2024-11-29 17:00           ` Sabrina Dubroca
2024-12-01 23:43             ` Antonio Quartulli
2024-11-21 16:02   ` Sabrina Dubroca
2024-11-21 21:43     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 19/23] ovpn: implement key add/get/del/swap " Antonio Quartulli
2024-11-05 10:16   ` Sabrina Dubroca
2024-11-12 15:40     ` Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 20/23] ovpn: kill key and notify userspace in case of IV exhaustion Antonio Quartulli
2024-11-05 10:33   ` Sabrina Dubroca
2024-11-12 15:44     ` Antonio Quartulli
2024-11-13 14:28       ` Sabrina Dubroca
2024-11-14 10:38         ` Antonio Quartulli
2024-11-20 12:17           ` Sabrina Dubroca
2024-10-29 10:47 ` [PATCH net-next v11 21/23] ovpn: notify userspace when a peer is deleted Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 22/23] ovpn: add basic ethtool support Antonio Quartulli
2024-10-29 10:47 ` [PATCH net-next v11 23/23] testing/selftests: add test tool and scripts for ovpn module Antonio Quartulli
2024-10-31 10:00 ` [PATCH net-next v11 00/23] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2024-11-01  2:12   ` Jakub Kicinski
2024-11-01  2:20 ` patchwork-bot+netdevbpf
2024-11-06  1:18 ` Sergey Ryazanov
2024-11-14 15:33   ` Antonio Quartulli
2024-11-14 22:10     ` Sergey Ryazanov
2024-11-15 15:08       ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b868dcf1-7c0d-4511-8016-89302e7cb9c4@openvpn.net \
    --to=antonio@openvpn.net \
    --cc=andrew@lunn.ch \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=sd@queasysnail.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®