From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760967AbcLPNil (ORCPT ); Fri, 16 Dec 2016 08:38:41 -0500 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757456AbcLPNid (ORCPT ); Fri, 16 Dec 2016 08:38:33 -0500 Subject: Re: [PATCH] ubifs: ensure zero err is returned on successful return To: Colin King , Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org References: <20161216133239.21547-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Richard Weinberger Message-ID: Date: Fri, 16 Dec 2016 14:38:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20161216133239.21547-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.12.2016 14:32, Colin King wrote: > From: Colin Ian King > > err is no longer being set on a successful return path, causing > a garbage value being returned. Fix this by setting err to zero > for the successful return path. > > Found with static analysis by CoverityScan, CID 1389473 > > Fixes: 7799953b34d18 ("ubifs: Implement encrypt/decrypt for all IO") > Signed-off-by: Colin Ian King > --- > fs/ubifs/journal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c > index a459211..b75f1a6 100644 > --- a/fs/ubifs/journal.c > +++ b/fs/ubifs/journal.c > @@ -1319,6 +1319,7 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in > dn->compr_type = cpu_to_le16(compr_type); > dn->size = cpu_to_le32(*new_len); > *new_len = UBIFS_DATA_NODE_SZ + out_len; > + err = 0; > out: > kfree(buf); > return err; > Good catch! Thanks, //richard