From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED7634FF63 for ; Wed, 11 Feb 2026 22:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770850739; cv=pass; b=dhOjLS1Xn/LAOFxYQdKJ0lNi7zIEBHFG8E8GIBTJ0wvTlHBkXX6468Od9X9Za6IUYii1tEyILeyVc1Hc/1IPUDhmXNmImpn4PtAWNEcB95jvyDyqKyV5GsTJCBR55kJP1kYr/FU8FWUin8tiuHXDYc7KsQnd5/Bv03DYNlt49pg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770850739; c=relaxed/simple; bh=srf3xjhvd9z9Ci5sLW1yNHQKrzcasC6YfvtI39BlR78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G1ippkanfugotXsYW9IsiDX0RYb+zNKXsRNzJ168rT9BLL9ujvnRBD1moEf2Ro4mkReWea034IIcq0uVJdxQnAIwRvKLgWRc/jgXUMgw/MRS2c1McxOMA52z8Hvw/5fHM4XnrOSdjFBQEljWAhP//05iKz1s3zkKe3lDfYyNaBY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b=dV2CXZ+n; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b="dV2CXZ+n" ARC-Seal: i=1; a=rsa-sha256; t=1770850716; cv=none; d=zohomail.com; s=zohoarc; b=MxrOMo5d6/mJLR3+tUr/QJOPUIJA9cntXWv0C+UXRGHuFnYnUhFHXZLAg9Do0Sp4G/udJUKK30LPgilaIA6B5lmlNexQKFSEYVqbeJ92jtb1UBHIWy5p85BpEzRQFfy+IsKO+DDUB0Awt/h51ePZ5LWwKZRJNO0hGTdYx2B9vfo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770850716; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=u0fIcMRjfAcgBBlHlVGAIBXjKC32Ith8CmSk3y8tjw4=; b=btUEEGGChSWJrNze8wxO0fn4dsXVjtE7xotft1YJ6IRizM07JI1ueSe2/ft5c0Zgf7Ooy4wJ62r0ZNoDfknLN2E1lehDM5Z97zais42E2NGnuQX1kMDEuyzU5ahyMM/8m0S92jV8W0QETLiTxu9clURzg4CMQCnsFMUXRHB5mNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770850716; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=u0fIcMRjfAcgBBlHlVGAIBXjKC32Ith8CmSk3y8tjw4=; b=dV2CXZ+nnyCjfjQYasMF0k3Wkawiiy35BCr5U+qqNnq1uneOdZlIoQVZgZXzYLEf Sy8UnfWlQfVYFXkZiZYy7EG1PAmizit1vlNpo9SLKH29GL18I28ETLEGiKWBubnP49H 7LLh0saY+6CErcS6EbvD3EUwmY9DYyOdcr+mlP2g= Received: by mx.zohomail.com with SMTPS id 1770850714342875.3506197676041; Wed, 11 Feb 2026 14:58:34 -0800 (PST) Message-ID: Date: Thu, 12 Feb 2026 01:58:29 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/virtio: Allow importing prime buffers when 3D is enabled To: Val Packett , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Vivek Kasireddy Cc: Dongwon Kim , Christian Koenig , dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251210154755.1119861-2-val@invisiblethingslab.com> From: Dmitry Osipenko Content-Language: en-US In-Reply-To: <20251210154755.1119861-2-val@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 12/10/25 18:39, Val Packett wrote: > This functionality was added for using a KMS-only virtgpu with a physical > (or SR-IOV) headless GPU in passthrough, but it should not be restricted > to KMS-only mode. It can be used with cross-domain to pass guest memfds > to the host compositor with zero copies (using udmabuf on both sides). > > Drop the check for the absence of virgl_3d to allow for more use cases. > > Fixes: ca77f27a2665 ("drm/virtio: Import prime buffers from other devices as guest blobs") > Signed-off-by: Val Packett > --- > > Hi. I couldn't find any comments on that line in the reviews (on patchwork), so I assume > there was never a specific technical reason for that check, just an abundance of caution? > > BTW, while here.. The drm_gem_prime_import "fallback" seems pretty much equivalent to > `return (-ENODEV)`, as drm_gem_prime_import(_dev) just translates the call to > gem_prime_import_sg_table which we don't use. Should it be replaced with `return (-ENODEV)`? > > --- > drivers/gpu/drm/virtio/virtgpu_prime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c b/drivers/gpu/drm/virtio/virtgpu_prime.c > index ce49282198cb..2fedd5d3bd62 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_prime.c > +++ b/drivers/gpu/drm/virtio/virtgpu_prime.c > @@ -312,7 +312,7 @@ struct drm_gem_object *virtgpu_gem_prime_import(struct drm_device *dev, > } > } > > - if (!vgdev->has_resource_blob || vgdev->has_virgl_3d) > + if (!vgdev->has_resource_blob) > return drm_gem_prime_import(dev, buf); > > bo = kzalloc(sizeof(*bo), GFP_KERNEL); Reviewed-by: Dmitry Osipenko -- Best regards, Dmitry