From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Keerthy <j-keerthy@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: mark PM functions as __maybe_unused
Date: Fri, 6 Jul 2018 10:26:19 -0700 [thread overview]
Message-ID: <b87566e9-c398-d390-e029-0a28b2c7fbf9@oracle.com> (raw)
In-Reply-To: <20180706123651.2792927-1-arnd@arndb.de>
On 7/6/18 5:36 AM, Arnd Bergmann wrote:
> Everyone gets these #ifdefs wrong, leading to another warning here:
>
> drivers/soc/ti/wkup_m3_ipc.c:547:12: error: 'wkup_m3_ipc_resume' defined but not used [-Werror=unused-function]
> static int wkup_m3_ipc_resume(struct device *dev)
> drivers/soc/ti/wkup_m3_ipc.c:539:12: error: 'wkup_m3_ipc_suspend' defined but not used [-Werror=unused-function]
> static int wkup_m3_ipc_suspend(struct device *dev)
>
> The easiest way to get it right is to remove all the #ifdefs and
> let the compiler drop the unused functions silently after we
> mark them as __maybe_unused.
>
> Fixes: 7a872b6fb7fd ("soc: ti: wkup_m3_ipc: Add rtc_only with ddr in self refresh mode support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied. Thanks Arnd !!
Regards,
Santosh
prev parent reply other threads:[~2018-07-06 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 12:36 Arnd Bergmann
2018-07-06 17:26 ` santosh.shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87566e9-c398-d390-e029-0a28b2c7fbf9@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=arnd@arndb.de \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®