From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85823481FBB; Wed, 21 Jan 2026 12:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000180; cv=none; b=ZjEarPLXVynfz78Osm4b8i4FCaJu5tZdzSEcFuZYFPmPfiA1zlZCdZPIQg001fvVa2s3eNeXXfHDzXJtB6ap7WXp2KU9obkd7U+pgtNE9qfAjYlioiVqLNj32yJjK1pBrttM60XeD6uGxXQiCRz32rmOE99E01dO7Ppym7JbFOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000180; c=relaxed/simple; bh=66z6mDXJKNQlh26TNqfhAkuHv1OKeUZGPN22b6g7GpE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YfR6cR+Vi1UEoOiUxJSOVmLf0U8FcUW3rhYrPP93R97BwLPGX/WKGfel/aFNNbMjhvRzIpXBWAeyz3UTAt7AFtmvbc6/aEjUtOvj2THWeg5cshEgwm0V9NzfhHOg9jIW6nmR/gpVdhKhnaIEUoMJVgOGgcssnupyJDrBWzYMnww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=HG5oS4Qb; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="HG5oS4Qb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=QjCA++DUfFEMwVur9OmsdI0vgUZoTw8UrQCFGMt/NHM=; b=HG5oS4Qb2N80+3woHabiOAIFBS 3e+uV4TVaFVFGmHiQqkHBvce3bOE4MIAFDFCGpEBrg1ltRGpAUlRUlBqZZCzlFGUOcX0gjNnRokNy zu4SjkKqcTkxxKQYraItvTWlSs95lvP1TkY54JUgu7RJVqYSi/spCRsWu00FhmraSx8Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1viXkb-003oo1-FE; Wed, 21 Jan 2026 13:55:57 +0100 Date: Wed, 21 Jan 2026 13:55:57 +0100 From: Andrew Lunn To: Chaoyi Chen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Alexey Charkov , Shawn Lin , Sebastian Reichel , Chaoyi Chen , Andy Yan , Nicolas Frattaroli , Detlev Casanova , Stephen Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1 Message-ID: References: <20260121031548.402-1-kernel@airkyi.com> <20260121031548.402-2-kernel@airkyi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260121031548.402-2-kernel@airkyi.com> > @@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 { > reset-assert-us = <20000>; > reset-deassert-us = <100000>; > reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>; > + tx-internal-delay-ps = <1950>; The PHY should add 2000ps, as required by the RGMII standard. The difference is so small there is no need for tx-internal-delay. In most cases, 'rmgii-id' should be sufficient, unless the PCB is badly designed. Andrew