From: Andrew Lunn <andrew@lunn.ch>
To: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sagar Cheluvegowda <sagar.cheluvegowda@oss.qualcomm.com>
Subject: Re: [PATCH net-next v3] net: phy: aquantia: Add support for 5GbaseR
Date: Thu, 29 Oct 2026 14:28:18 +0100 [thread overview]
Message-ID: <b87d66ca-dbd3-412a-9ebc-055f8e6f9a6f@lunn.ch> (raw)
In-Reply-To: <20261029-aquantia-support-5gbaser-v3-1-f1f9346553d0@oss.qualcomm.com>
> @@ -786,7 +790,8 @@ static int aqr_gen1_config_init(struct phy_device *phydev)
> phydev->interface != PHY_INTERFACE_MODE_10GKR &&
> phydev->interface != PHY_INTERFACE_MODE_10GBASER &&
> phydev->interface != PHY_INTERFACE_MODE_XAUI &&
> - phydev->interface != PHY_INTERFACE_MODE_RXAUI)
> + phydev->interface != PHY_INTERFACE_MODE_RXAUI &&
> + phydev->interface != PHY_INTERFACE_MODE_5GBASER)
This is sorted based on speed. So 5GBASER goes earlier in the list.
> {
> if (iface == PHY_INTERFACE_MODE_10GBASER ||
> - iface == PHY_INTERFACE_MODE_2500BASEX)
> + iface == PHY_INTERFACE_MODE_2500BASEX ||
> + iface == PHY_INTERFACE_MODE_5GBASER)
> return RATE_MATCH_PAUSE;
Please keep this in order, 10, 5, 2.5.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-10-29 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 5:47 Hongmei Xu
2026-10-29 13:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87d66ca-dbd3-412a-9ebc-055f8e6f9a6f@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagar.cheluvegowda@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®