From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA22E3D564E for ; Thu, 7 May 2026 10:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778149236; cv=none; b=tTWxhkwgdXgzto27hSKbU6HicLm31RbJY3q3iZQpdNObF5YgKjHTi6fEqt3F5oZoCHj4NuZ2wKRRisvvyoKoYpN7MnZqorNvVfJWhsbbQn4gq/Q185HD9ya3aM/3x38l3iIN8O2fbnvczv5n2uyPVYH43FcfAc54vAavk4h2XaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778149236; c=relaxed/simple; bh=2avxSsvk1as1FMY6RZX9B99PtZTW8XOT31jV6eVZ6xg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ABoiSMg841QSMIx3OTVID8FQjWRd/pFdHxgZXj4CCh4kn75AwJLcrlNFSCoEFfiePmjYLC7p5SeDyZFs5mR0y31uTaJJ5QWRnWFcSgaB2ShC6QYf+/7xQ/tWDfbWTQig4s3Cega8ohsUW92Tc/W6tMdxD2W3CCajxC0X8aJvHq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SIuYQE42; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kWc+S58E; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SIuYQE42"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kWc+S58E" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479mKjI026622 for ; Thu, 7 May 2026 10:20:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /5khHSPAj9LWxns39r4VokImHha4yMAwLlWdMzY6C+E=; b=SIuYQE42z6i9X7IE qd1RPC+RB7OGD1KAd9WbNTvlFgF6j+gF1bnLfGmPzCWi1DlC97FXwcL/3aebILz9 fBurTT4pMlR0tiji3AsPG3GyTM1PstZWk/uAhvNUtnnE1XJeVE06eTKift4tN5iP LOrU7PWK/oWztzxL3Gql+YNg9f78klXntPo7aTvv5rlExtIbs2ze8Ij6ZP64pow7 PW+6russqldCZ+wQX8++Ej1gV79ILQegULNwUt9DyGDTIkRXZ5QxSUyUFoQinFH+ TlfWLs16veUtpHQTE0jaQQFVQTkI2YSC3X193c+pFi4aYSTJqh3kRPkxe4MVrUiO 8AYzDA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0k1t1e28-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 10:20:33 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba7662827fso13393405ad.1 for ; Thu, 07 May 2026 03:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778149233; x=1778754033; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/5khHSPAj9LWxns39r4VokImHha4yMAwLlWdMzY6C+E=; b=kWc+S58EfxZoqp9U/3xwxzOKx1MiMkkNxSbITRr8qG+NGuPtb/8hTZNplfWOgjzZpL A4XJ5zEWQK4KNqaiomQfgG8iLm5ZEzlDfx/jZoRggnSqkHIVaqn+klIteSGEH2tXJ2kJ O6EacYJZAnanQmtAhSkXlnqvkn+96Se/NSupeVSYcNoCSaAI+McPoLrcD/PCoFiyr1j3 NrTwYBMXWGfpkXBSZg/5vfwq96gydB8V5pVMw352Z+ZehRCq8R005EHO/yBgMCQgYBmv YZfLr0a4AAQ7fIi7DAR0ILqqx7otHtcN1g8Z6tCoVF8EGaiteGUFeM+HTO3TvhcNXCWM xCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778149233; x=1778754033; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/5khHSPAj9LWxns39r4VokImHha4yMAwLlWdMzY6C+E=; b=hZ9Edo8tV55jxmiczbKM2I4C/zG4RB+6Qd061pQbMtI8f46HXvmt6Svest1G1gqLT5 g/EW7iYDAVrGgD5xU5NNpEPOPkwnMNSY//eEOTqheFLAYdGIypc1udy5MP84QGSRtN/9 6vEtbImLFRc4HKAqomjNLMBxB3xx4z04DUEzrULH9qc67JxA3R71fn5IQ908wT6AwMn9 wQhf/6GppFb5OHdNgTj55puF9LIOUx+V38LLYUMmkkPXWweJM4vu+fglYe+Q00vlVr8G Qq4ha/YnqZfvj4N1Gxwfuo75uhAY85pwG5I15BElC8BZtJFZDOEK9ZL9K6rm2xiXXcFo CjmA== X-Forwarded-Encrypted: i=1; AFNElJ8wyRPtpdaELj14TzHF0cCvslHwbx3QcjGXrA28xDi3iwFMH+735+bXI0SYu74HFzH3yc3uJXnsL5wuufQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwSkJOVk2B6P81+EY6WHMZrbiaJ7gw+Q4+ed0Zak5Z0sQjfcDj1 Gs+8EDs/OrazpnnVNarCH8CN4YENiUZLVo3VGrlTJzrwpSROQQPggAUFSrCoTgD+wlQqfHQHtyX +hj5UINJJgSXAAaewIci4jVQpFdZQA0MYPu09Sh82DBg1BaCyFpyL3Nv1gKHT8+HoP8Q= X-Gm-Gg: AeBDieuLyQ5kYamGE82yzn0r+ebnZqppltQEfAzEj/gE22JyiEPs8463GsWtnfkfnSm USUDuf/tx696A49nv/hjQB5ATrWrnLWyzAGRPMIC2Aoa61LHKJDiwzFn9PJBnsjTF6qaZE1SspD R+vKmRn+jrqVk8MSKs3hsJlI6FPesn2u3VcPB0zPCbreDEEClY79rO+MpkZrB+MYcmZ1zPb+u/7 EL6o7/Wn6DWCnSqBFxkxdLbT8TFhnCg96lgeUy+ixvNIa2OduvbC8VXKMBig4Z5m+o4snXYt/xR fSPbWPISz4JHGlBdjk+++wbudpPK9Hta3VCR++HM67K4K2pAi43U3gYoCxGoJQl40jIJq9nqRo1 yqJq7vIR2pwwhhbhObCPhbKz7xYIbjZAtYS59O+MP1LZyWvW74r7z4YssX3HKJQ== X-Received: by 2002:a17:903:4b03:b0:2ba:21c2:d6cb with SMTP id d9443c01a7336-2babd4bdb6dmr19838365ad.16.1778149232149; Thu, 07 May 2026 03:20:32 -0700 (PDT) X-Received: by 2002:a17:903:4b03:b0:2ba:21c2:d6cb with SMTP id d9443c01a7336-2babd4bdb6dmr19837785ad.16.1778149231620; Thu, 07 May 2026 03:20:31 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babadef254sm20528445ad.61.2026.05.07.03.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 03:20:30 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 15:50:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk To: Bjorn Andersson Cc: "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Abel Vesa , Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Herbert Xu References: <20260416-qcom_ice_power_and_clk_vote-v5-0-5ccf5d7e2846@oss.qualcomm.com> <20260416-qcom_ice_power_and_clk_vote-v5-1-5ccf5d7e2846@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EoPiaycA c=1 sm=1 tr=0 ts=69fc6771 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=CMx50Ybjb1gtcuyIV48A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: N-z39O9Y-ZQ21KrtLduBOntNbpTrvfj1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEwMyBTYWx0ZWRfX+I50E0FNcSfR FfOa7BtaA8LEXdE5PHICvyfnMjRUMdxRA32GHaP2xIXfCFxEkd+rGHgmmCxPG3l1cVML3zAkkIt 7sZGJuWUUEl2mw/8Gpdg4CilH/gQFGy1DNLfoNij+3mPb62zYrq1+f66/YidGv6K9iGm5zuZ+ZN rEs7BTIsqYMq2invbjTJ0QpLARddXW/sWLjDpJfOgIWkjqlRRfiBaoOi4T/PimsMfOhnvIk5JYu s3NCVvdlwIRrwe5huxZSfFNK3ZwsIzJvQozl8rA9a8ci9wr4Jv28ILLz/r7Fml+lOYbYE8RK81p KKdZUiuiAzK4+UW2MBGlfjC4x4zDLsafXDBIvu+GhOkFR47MD+ghMHA9Fp3VKFxIgrtkchXMEP8 SrwF0XjslBkov4bqZQERr7dIE6La9Dc3AE8bEQdBeFaofSKHjmqFUEvo4cOnZEOjaY0t4jT2eyN A/rRppRbL+pDM4gK8bA== X-Proofpoint-GUID: N-z39O9Y-ZQ21KrtLduBOntNbpTrvfj1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070103 Hi Bjorn, On 5/5/2026 2:17 PM, Herbert Xu wrote: > On Thu, Apr 16, 2026 at 05:29:18PM +0530, Harshal Dev wrote: >> The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC >> power-domain and iface clock. Without enabling the iface clock and the >> associated power-domain the ICE hardware cannot function correctly and >> leads to unclocked hardware accesses being observed during probe. >> >> Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC >> power-domain and iface clock for new devices (Eliza and Milos) introduced >> in the current release (7.1) with yet-to-stabilize ABI, while preserving >> backward compatibility for older devices. >> >> Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE") >> Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE") >> Reviewed-by: Kuldeep Singh >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Harshal Dev >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++- >> 1 file changed, 34 insertions(+), 1 deletion(-) > > Patch applied. Thanks. Herbert has pulled out of picking this patch from his tree. As discussed, since this DT binding update relies on DTS changes in commits 12 and 13 of these series, they should all go through the same tree. Can we aim to pick this series via the qcom-soc tree to ensure the binding and DTS changes are applied together? Since the 7.1 fixes window is open, I am hoping for this to be picked up this week or the next. Regards, Harshal