From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577D3415F24 for ; Thu, 30 Jul 2026 12:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785413080; cv=none; b=upLwiootePITVrmYdZRySj3F+xypxMh5h0ZO3FmL2RagvRtGkJtoeMKrxNu43Z4xhrfRjPx2KeDcGvq5EEIECafrLooZ6umaDcsgpaSoKNxMCmEvZeJivJwj9y7Z5I4zZip+46ZYNCA5eYLsJvVQPj55wNGw2+7d5QzkGVdKVTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785413080; c=relaxed/simple; bh=I5BgxvP34n+zMbhzzcluW4RhyvS0Cz4tNpajXB8Dj0o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sBJtuyedzuaW0KAGxB0piSzIHufPtS37heOE9+lHlNUEWYj6rUrGBwHl6w65D4smGDTDJ9mLu6wuBFhxnUBMieHZ4KqGDoa0RSgTkIXigXllgt01pHbFkiUt/baKMyA6rg6zApZ7WkDmiYNkWH1JgWljxpE91DMeHpxwqu/oVVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VxApVZSm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CVp0wPAA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VxApVZSm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CVp0wPAA" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UBWCaY1144218 for ; Thu, 30 Jul 2026 12:04:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y+FHdhO5WfA1/EwScHXL3m5MMhllcwYguNR1eoqGLJ8=; b=VxApVZSmWdoJSwUo MGZbBJ27MkUlPpoENy82onsvqwj1TM2o7nONoxVwejHfWL+bxYRRUG6J9HNq/ulM KcxMzZFEyABTtlceMsC8iqHgWvwowkrdsknH4rSX3Hj8y+YomuCxlodN7bKlljHQ BZcdDua+QRgL+T27k/EhsoU7SDVVEJl3LhpG+a9giQF5SkqGvz5VTW7aD1NKRtZe 5NZl0OC23GMHmQA7EsuwaF5O1etPc9RTgfCpa7Pu668WLS7NqZIevk9yoTcQCiqe Pgw3eMJh0Zj6EYh9QPun9T5wZh0Jtrf9fWJFcpyG+74yIUOQTP7I8ebSqcjJa97E ST6Shg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr5tvr3mv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 12:04:36 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c01ff996dso22714721cf.2 for ; Thu, 30 Jul 2026 05:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785413075; x=1786017875; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y+FHdhO5WfA1/EwScHXL3m5MMhllcwYguNR1eoqGLJ8=; b=CVp0wPAAGH9oqx86Dbbzm8+6bDPGrl906QURni5opG1lnwdTthWOtGnVIkMJIDtHVJ g7PYHvevIXx6rn9vLfJm1JWkSO8tmjGv1A6laiFi3K39yzWE9KgigNldoD4CyteEWpdQ 39txHHlblqCBGejkxeJynk862ZEDWkVMdsdQxSfAFIlScroOsfiBz5RpGZ6t9y+TkxZv ePUHBuHbByhvVCaj/9yTGaBs3zg9kaQd3djvtggn+TEVN86ZVvpqQmiVnCJmVTUbtB5/ QwvCJ/uNkBE4fGjC1pwmtRDuspr7uWZrwFJqZxiV46Cys6VRc3aub2K0BsJOFYHl3Om+ 3Vfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785413075; x=1786017875; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y+FHdhO5WfA1/EwScHXL3m5MMhllcwYguNR1eoqGLJ8=; b=fxbmzd4Fq/CmxiyTFTLGdpGy7YOQxrIrk5zMgrt3cfD1Rk9D4SV4JzWP1kOKY3rS0S PeHKoFneudROIRQ+L/DjrJcOunPl1TkH7GLLlq04DWAzzgYx+20Vjp2Jhak2U2yLnDan Vm1BvU1ksvp7VYsbLwUfcI53hcGLUCagOUD3z5Km5HJ+DaXhUg2glqfNRyhghmr3OLtX CoEH7QXJi0dy501woEmMYbsifrsPvgggO7hvtdJsA+WzbuFahPK8Y+H1LVKNeVIhaZLe E0RTcmLaej9gztHmI1oBLVLdMH9ujzIBUpSp0TFxEMsrrkYgqRqah+5e/dCpuTsqHcqO sRLQ== X-Forwarded-Encrypted: i=1; AHgh+RqOHK81AgzRrJYY7YySOlst13wpkSTmnTYMd2bfKWD+zMDrT2H5iob7l+j5FmxBbYzRalN0QwFu2JfpieY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9FCRRMzlHJ7DdseROLOpPjtwlKbIyj7/c1s4WIpCrLOyoGat9 BjzdAPTpS93HOi5EKdhXCBBhurmSuNjOeO4hvos8vdupHieqLM0sCCnz3uY4w1di093nTHuHZJa 2kvUNb7S/JQbmBUyzpKNUZGZaAPErzFlpmkFllQD2WEA7U5BugN2lyEc0pS8X6+sS0y8= X-Gm-Gg: AR+sD12PP2I8/UzJFitnFiaYkAabpoNVpUofWaI7rtKa8TNnWkbmUSws6xjgFPk8RXF lmifd23y0qf8d+jUbVWJ4ZVuiXtuEBnBuWtwRQvR8wcxwLb5FbcC6Vd2tK16sTnnwZLr19N3A5Z C/7BQVPbvR1zSwftgByhZ9AIlT8d/5L8Y7QyAmUqXx+XjpgEY8KAaKQLs1KXFhGxsS2xbC92cxL KaXFOLPEvLLdsAeiKK6nk/EUz0VsBscCU0Nej/5yzkMQvuqnThrMkHmfbpGha7fwjMiUCRB3aWn 3llOzpDPxEkVP1DhYk59D5BQ2STxelvl7SjRsqsXy3Gsz53LbU0A+Qi04Ua/dW7LsHt0/7NRbE+ iOil1cJdE23xs+XbOiLl6FUoruKs= X-Received: by 2002:a05:622a:14c9:b0:51c:7b12:1202 with SMTP id d75a77b69052e-52b386c73d5mr21919551cf.80.1785413075258; Thu, 30 Jul 2026 05:04:35 -0700 (PDT) X-Received: by 2002:a05:622a:14c9:b0:51c:7b12:1202 with SMTP id d75a77b69052e-52b386c73d5mr21919061cf.80.1785413074645; Thu, 30 Jul 2026 05:04:34 -0700 (PDT) Received: from [192.168.68.105] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-c1fa8b76116sm59455366b.41.2026.07.30.05.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 05:04:33 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 13:04:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] dt-bindings: pinctrl: qcom,hawi-lpass-lpi-pinctrl: Add Hawi LPI pinctrl To: Prasad Kumpatla , Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski References: <20260724141708.2212057-1-prasad.kumpatla@oss.qualcomm.com> <20260724141708.2212057-5-prasad.kumpatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260724141708.2212057-5-prasad.kumpatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA5MSBTYWx0ZWRfX6yYREfzTMnhJ 0XtD0S0X/Jb8V0aISklPYq9jwQY4rR6q3H3JTH4BDKuArp3aNk48o7aIh0AptB+YiVU6q/E3Y9B w36Xkx5jKB9F+kGZrWDU9SJM86xbjJY= X-Proofpoint-ORIG-GUID: p79kJxub88lJVohxx0g6gRWZTZdBqfFh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA5MSBTYWx0ZWRfX+/IaALJGFhJX BBHzwv24a8iQsIa8qrfVRo4uSme7CwFp2NMrvJJT8qD11ml0Ff1TbRIO1bR7EiETiZlDCfqTvFJ eOW7FZER9f9AM8YMSL4wg3lTd9YCH9ZnsNGKs+xkFncw5G8lY2LHo+b+XeF2Wj/tmA1hy/sOPZk EaHXWqsx0aVLm+zJo0DXLpoVzVzfUJ6aE7/bdf92nHplBh4GXr18+hmqZXJLSBk7L1FJFPMFg+E rTwsEg9+kdyW4nQQseW5xnDWNktdcWOIcXggOQCraPmMMUwRjIREr4KAltcWAyUdAsaPuaCVsvm RJbqcwx7+xqOA8AXr4aiTiEp8JB8LrlBHebOfWnKEfp1SoGrGS3RW2JldqzoO2pFgD5t7BwojAw p+v8cKwGcyQzpzue+CSZU+5B+HJdJgAEqzlWoXnwN25dNWYYdAR/ojJpfPVBheuSA4bRQS9RHov h3H/+4v3E02s0P86kWQ== X-Authority-Analysis: v=2.4 cv=ULPt2ify c=1 sm=1 tr=0 ts=6a6b3dd4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=DP1ofWnUcdAMOgPlYdMA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-GUID: p79kJxub88lJVohxx0g6gRWZTZdBqfFh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_03,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300091 On 7/24/26 3:17 PM, Prasad Kumpatla wrote: > Add bindings for the pin controller in Low Power Audio SubSystem (LPASS) > of Qualcomm Hawi SoC. > > The controller has 23 GPIOs (gpio0-gpio22) with functions including > SoundWire, I2S, DMIC, VA I2S, ext_mclk1, slimbus and lpass_lpi_dbg_clk. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Prasad Kumpatla > --- > .../pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml > new file mode 100644 > index 000000000000..af68581750cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,hawi-lpass-lpi-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Hawi SoC LPASS LPI TLMM > + > +maintainers: > + - Krzysztof Kozlowski > + - Srinivas Kandagatla > + - Prasad Kumpatla > + > +description: > + Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem > + (LPASS) Low Power Island (LPI) of Qualcomm Hawi SoC. > + > +properties: > + compatible: > + const: qcom,hawi-lpass-lpi-pinctrl > + > + reg: > + items: > + - description: LPASS LPI TLMM Control and Status registers > + > + clocks: > + items: > + - description: LPASS LPR(Low Power Resource) voting clock > + - description: LPASS Audio voting clock > + > + clock-names: > + items: > + - const: lpr > + - const: audio > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-hawi-lpass-state" > + - patternProperties: > + "-pins$": > + $ref: "#/$defs/qcom-hawi-lpass-state" > + additionalProperties: false > + > +$defs: > + qcom-hawi-lpass-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state > + unevaluatedProperties: false > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + pattern: "^gpio([0-9]|1[0-9]|2[0-2])$" > + > + function: > + enum: [dmic1_clk, dmic1_data, dmic2_clk, dmic2_data, dmic3_clk, > + dmic3_data, dmic4_clk, dmic4_data, ext_mclk1_a, ext_mclk1_b, > + ext_mclk1_c, ext_mclk1_d, ext_mclk1_e, gpio, i2s0_clk, > + i2s0_data, i2s0_ws, i2s1_clk, i2s1_data, i2s1_ws, i2s2_clk, > + i2s2_data, i2s2_ws, i2s3_clk, i2s3_data, i2s3_ws, > + lpass_lpi_dbg_clk, qca_swr_clk, qca_swr_data, slimbus_clk, > + slimbus_data, swr_rx_clk, swr_rx_data, swr_tx_clk, swr_tx_clk1, > + swr_tx_data, va_i2s0_clk, va_i2s0_data, va_i2s0_ws, > + wsa2_swr_clk, wsa2_swr_data, wsa_swr_clk, wsa_swr_data] > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > +allOf: > + - $ref: qcom,lpass-lpi-common.yaml# > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + lpass_tlmm: pinctrl@7f60000 { > + compatible = "qcom,hawi-lpass-lpi-pinctrl"; > + reg = <0x07f60000 0x20000>; > + > + clocks = <&q6prmcc LPASS_HW_LPR_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; TBH, you could have used integer instead of define here, which could have made things easy for maintainer to merge the series. --srini > + clock-names = "lpr", "audio"; > + > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpass_tlmm 0 0 23>; > + > + tx-swr-sleep-clk-state { > + pins = "gpio0"; > + function = "swr_tx_clk"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + };