From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FCF0311968 for ; Wed, 19 Nov 2025 12:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763556938; cv=none; b=oxAo0I6dEN+mBcqLK5FMxrwi82OnyS9+Gy6TFF1VtUgFpPAx6/du2KhtIyZLfbLRv1TDZ4CR8dXQa7ueQwfkY5lCkQXJDW/LoxDQfgw5javxO//UqCz+3KAMn8UBcI2KWDtmdrPCNjmyO7yP4RIHaqAU8JJ831B+3flZkRV930k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763556938; c=relaxed/simple; bh=ManCGk0RMc1nXXjrblonBiJYCDoBbqHCguM+SXPk67I=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=G+wkJB4iObVHxLN9fDMksSO4VmNSXoao91q5T+xFcbNBeTvHt4iVLKcfupf3wGbG12mHWXdxBMfSmypCdtbVxtEp9g/hpxNl6kTq26n0uuVAwn0fnmhhphhGOfHV8Yu2r6BiKSdCCEaeSltOrqy1J3cmfEq1yo85rXk3iCYYEpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=O0HWHi2f; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=BOZj9SHV; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="O0HWHi2f"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BOZj9SHV" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id E1F7D140016A; Wed, 19 Nov 2025 07:55:34 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Wed, 19 Nov 2025 07:55:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1763556934; x=1763643334; bh=SIeRETOUtrzELFBd5S1h4AlzLBWySd1AFbWOh+Xv9EQ=; b= O0HWHi2fJqeZOK2PzCn+4WRc33ZIpMTu2nw59xDpKrKNwoMJnT1g9VuJN4kw6OWo UOtfeDENFxnR2KQQmNJj7xVU+Svd+BLcZAieIuTnjMlVcsNkZgjRkBo6R7F7MO+S mpKPOqBg9P2wzQOpJyDjYY4H/UEPno3lup+TP4GEByRpw8kzi8huyoyK4wWLsVql 6CfPBZeq8+F4QiwAwdJG67ufPi/hHFHhH3RAl+Y2Y5gcQmA6+OJ5oqOzFLJzN1yF pcH9imNJPb1z0YfMiV4G0WWHBpYec4AAwXCXZKQzQOfVBggvYGg/CDigTQjeOO19 7yV/n8qKLYIACL7CAH3Nug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763556934; x= 1763643334; bh=SIeRETOUtrzELFBd5S1h4AlzLBWySd1AFbWOh+Xv9EQ=; b=B OZj9SHV6Xyg7NBErqXGOS+hyyXTAsNrYq42LfBhKPL6Ih0dlf2xjnIVd+LlmN5/H xWmd2hZ0ef36b0PkUeZtTOHKkMPgW57nEfiSycFmUgnpuodmSFGuF0TrgdEFPhAK tyLiHgNMk4Ek19v1lBZzLjk6sweCJ05KUtOCYAU+5oSuOayMzljJO/ylR8gn0ZQ7 v6aQsnTBoXyj4XFaXmDy8Ngtr08qGaLnStAvuhXQAi1ST36PGre6sr9I61KmXHvw dN9SHtlfSSCYa2dom82r1W2hZoHBAs1qI5DoTilqjPpX9ddA9SZUF7OX/8jXoPgf lDkVE0KO/BSXVw08prpLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvdegvdeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrnhgu uceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvg hrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefhvdei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnh gusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepjhhirhhishhlrggshieskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh epghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohep lhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id AF298700054; Wed, 19 Nov 2025 07:55:34 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AEN-XW29e7uJ Date: Wed, 19 Nov 2025 13:54:54 +0100 From: "Arnd Bergmann" To: "Jiri Slaby" , "Greg Kroah-Hartman" Cc: linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20251119091949.825958-1-jirislaby@kernel.org> References: <20251119091949.825958-1-jirislaby@kernel.org> Subject: Re: [PATCH 0/6] char/mwave: cleanup Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Nov 19, 2025, at 10:19, Jiri Slaby (SUSE) wrote: > Hi, > > the driver is in a bad shape -- this is a minimal cleanup, so that it is > more or less readable. > > Jiri Slaby (SUSE) (6): > char/mwave: remove dead code > char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery > char/mwave: remove unneeded fops > char/mwave: remove printk tracing > char/mwave: drop printk wrapper > char/mwave: drop typedefs The cleanups all look good to me, Acked-by: Arnd Bergmann I assume you are not actually trying to use this driver, right? According to thinkwiki.de, the 3780i modem was only used in a couple of Thinkpad models that are now over 25 years old, using Pentium II processors, and they all have a physical RS232 port that can be used to connect an external modem instead. Maybe we can just retire this driver? Arnd