From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031509AbdADQiZ (ORCPT ); Wed, 4 Jan 2017 11:38:25 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:33600 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933084AbdADQiW (ORCPT ); Wed, 4 Jan 2017 11:38:22 -0500 Subject: Re: [PATCH] clk: clk-conf: Do not print error messages if EPROBE_DEFER To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd References: <1483524753-32213-1-git-send-email-geert+renesas@glider.be> Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: Date: Wed, 4 Jan 2017 13:39:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1483524753-32213-1-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2017 11:12 AM, Geert Uytterhoeven wrote: > EPROBE_DEFER is not an error, hence printing an error message like > > clk: couldn't get clock 0 for /soc/display@feb00000 > > may confuse the user. > > Suppress error messages in case of probe deferral to fix this. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Marek Vasut > --- > drivers/clk/clk-conf.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c > index 674785d968a3e1c5..e0e02a6e59009e7a 100644 > --- a/drivers/clk/clk-conf.c > +++ b/drivers/clk/clk-conf.c > @@ -40,8 +40,9 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier) > return 0; > pclk = of_clk_get_from_provider(&clkspec); > if (IS_ERR(pclk)) { > - pr_warn("clk: couldn't get parent clock %d for %s\n", > - index, node->full_name); > + if (PTR_ERR(pclk) != -EPROBE_DEFER) > + pr_warn("clk: couldn't get parent clock %d for %s\n", > + index, node->full_name); > return PTR_ERR(pclk); > } > > @@ -55,8 +56,9 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier) > } > clk = of_clk_get_from_provider(&clkspec); > if (IS_ERR(clk)) { > - pr_warn("clk: couldn't get assigned clock %d for %s\n", > - index, node->full_name); > + if (PTR_ERR(clk) != -EPROBE_DEFER) > + pr_warn("clk: couldn't get assigned clock %d for %s\n", > + index, node->full_name); > rc = PTR_ERR(clk); > goto err; > } > @@ -99,8 +101,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) > > clk = of_clk_get_from_provider(&clkspec); > if (IS_ERR(clk)) { > - pr_warn("clk: couldn't get clock %d for %s\n", > - index, node->full_name); > + if (PTR_ERR(clk) != -EPROBE_DEFER) > + pr_warn("clk: couldn't get clock %d for %s\n", > + index, node->full_name); > return PTR_ERR(clk); > } > > -- Best regards, Marek Vasut