From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E6CA33262A for ; Fri, 3 Jul 2026 20:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783110596; cv=none; b=MZ59Tviai99udONXaRc2ohLg46lk/lvTG8sGGOk6NkJ0T5lKGnJAkMy3V8SoOZJI8LI9ZlIi97zD3Jh0PVUSyxdqNL5WZVr2nksMm2Fa7WdaXZCTfgZ+lJxNhRTMjfP17bJHiQSRg8P4woaGNwkWoxa1r9f6i+CiPKdk73arFIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783110596; c=relaxed/simple; bh=TJ1Yp+Qwil//MuisP32HdTlaRDeb8Set3TLhKZIhdN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IwIrKWzqF24aMQ1kzWL1JGIzg5Z+gxwVNFWHeDbo50Wm70q5812MLzyY1jcza3IqL2DqvDQhq5NuLUYWpQwLvHL3LFTwdTXHEfh1p7yA5pr4qGdzcLZ/XXAEw7F/ISlyIb3T1UdVEELOgePcbvRt4rl5ZVXYJSldUEOt/SyAhmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=oV3DrLZ+; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="oV3DrLZ+" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7e9d7464b71so285213a34.0 for ; Fri, 03 Jul 2026 13:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783110593; x=1783715393; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gw65i8xoQ4Rdi81NgA4DFcrACy+bTuTMIx3V9X+aMLw=; b=oV3DrLZ+enF+1OpejGNA+zZ9DyoawFqu0KnsySh3cZzAdNPuJsZr4r7cq3Vh/oXevc J+jcF0V9yV/Ej+klr3zbkcbqPzYyboz9W9/aEH0Kd/QJlZY0uZ2U0TlcVUUo80MWrl5J i6aZAUNTtXFvWzMe5sLl6UM8KrNxrRkIkaeAMV7TQabGNihvml5on4GPA19vpBl2JIPc qpy/OilSxfFJuuzuLVk+ai0It1pXTCzWQxytZqfCfxOxlI2Eo3ZNY368khcMhiYFXq2s XqlcGzVeIZYwP60XLgEv3MZObb5b4LuqS2KHUBbb4U2ahydRmmmdr/r2cVseB1KykT4s cS+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783110593; x=1783715393; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gw65i8xoQ4Rdi81NgA4DFcrACy+bTuTMIx3V9X+aMLw=; b=C0dd4xdL8LP/KyRGOii/V0tzCAjl3l/aUj8dLJjKaLUNvjzRfdG9DpX5uzbs9ZPGpC nBVVoGwrCpvn3PbbgcC4AiKIqvS17N82NaKmvkZLlXeQHJDX1Rq391aK83Ya3FcpOsME 0t6yjZeVKMcuno2GZiTbRkKHLQYL5JJvId8yoazWK2VwYVWkQKUaiaVyrteacJdYWrGZ 1BmPDdoDpqy7IcuQmw5uagOvnMn3u4MwOCctvZ9d9i1pfwmVtYKRTxdqIw/cQuGJcBTK 0SlLl3oqTILCyY5oUsIL26eTHqjNJZNNOq9BXvrfLAj2jFRAx5uQxJisBda1IlZsic9M haCw== X-Forwarded-Encrypted: i=1; AFNElJ/7zVwIQ4LbIGCtST7lYdMaBPlizfEbqOij81as/gNWgN6BSzSCcGC3ZSuqOjzIbF6cEuyvC0PelYsc7qo=@vger.kernel.org X-Gm-Message-State: AOJu0YwncBJRMYtWGHRvwMzT8G2VXyEXgAytLldJasNROAYqTgqr5S1I fr1DfUTymHYIUVCzUBgmf2fdCl433WOUwt/3EcNAgs4Hp3QdKzTJzyeflRen6/vKVCnCLWA1nEo HrIqW X-Gm-Gg: AfdE7cloHJyMeCi2KgG+D9xhFJt+z4lSIO0r8+0VkSuJMhS7rVa+RPXZdnfUeDm784C 2QSQst1u19iyQRxU2jha1IA/HU0iIr+7DQpvWR3xQVUnGQvL0RFp8t6jzpEhTUMpOQ3+8BXx0eh +vAtwRjE9nOl5BXM9bXUMIxrj1i9H4PoCgzF4SF+Y+ReQ+E9t6TLublaMt6hQf6ZDnhHUcriJ5g l2wXzfbn4HH2eROjvg/BQ9AJrqTup7d5Yucm7sFL50M/YtVZd4qdWmQ4QZwoIDoDc2zfZ4YiVvZ CHNbxyk28lIScg6NL+2v8wzDqem/lZuZG5BtoW91uXxHFp91kF0q9jRQc8pxN4QTVpBWcktA3/b UAprp1SLEqXJwXYMQwWMbEV1qZAzTLhO92sobggqg2XhCWLL3GkyDad8J12fYIqhdkTLLW3dT9J 3mGk1vidaqhLRtZbPmiB40vDPpzzS2a9l9Ltq1SGhJLBrxZ/tWGss1aT3AYCTli7Q= X-Received: by 2002:a05:6830:2e07:b0:7e9:b4cf:683d with SMTP id 46e09a7af769-7eb7ff7c01cmr704096a34.29.1783110593167; Fri, 03 Jul 2026 13:29:53 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:6af9:a9d7:17b5:2644? ([2600:8803:e7e4:500:6af9:a9d7:17b5:2644]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7eb54292d5fsm5785830a34.6.2026.07.03.13.29.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 13:29:52 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 15:29:51 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] iio: adc: add MAX40080 current-sense amplifier driver To: Siratul Islam , Stefan Popa , Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ciprian Hegbeli , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260703102941.1141341-1-stefan.popa@analog.com> <20260703102941.1141341-3-stefan.popa@analog.com> <9878f042f424bfbd7fab24175298224b58e87779.camel@linux.dev> Content-Language: en-US From: David Lechner In-Reply-To: <9878f042f424bfbd7fab24175298224b58e87779.camel@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/3/26 2:42 PM, Siratul Islam wrote: > On Fri, 2026-07-03 at 13:29 +0300, Stefan Popa wrote: >> The MAX40080 is a bidirectional current-sense amplifier with an >> integrated 12-bit ADC and an I2C/SMBus interface. It measures the >> voltage across an external shunt resistor and the input bus voltage, >> storing the results in an internal FIFO. >> >> > Hi! I already looked at Andy's review and decided to add a few more stuff. > ... >> +#define MAX40080_REG_CFG 0x00 >> +#define  MAX40080_MODE_MSK GENMASK(2, 0) >> +#define  MAX40080_PEC_EN_MSK BIT(5) >> +#define  MAX40080_RANGE_MSK BIT(6) >> +#define  MAX40080_FILTER_MSK GENMASK(14, 12) > Should be one space after #define, like the first one. >> + Actually, Jonathan likes to have the extra space to group the fields of the register under the register address like this. And even better is to include the register name in the field macros too, e.g. MAX40080_CFG_MODE_MSK.