From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] iommu/dma: add missing support for DMA_ATTR_MMIO for dma_iova_unlink()
Date: Mon, 24 Nov 2025 19:46:12 +0100 [thread overview]
Message-ID: <b890945a-49af-4c45-a325-0fb106be7832@samsung.com> (raw)
In-Reply-To: <20251124181752.GX233636@ziepe.ca>
On 24.11.2025 19:17, Jason Gunthorpe wrote:
> On Mon, Nov 24, 2025 at 06:09:55PM +0100, Marek Szyprowski wrote:
>> Commit c288d657dd51 added support for DMA_ATTR_MMIO attribute in the
>> dma_iova_link() code path, but missed that the CPU cache is being also
>> touched in the dma_iova_unlink() path. Fix this.
>>
>> Fixes: c288d657dd51 ("iommu/dma: implement DMA_ATTR_MMIO for dma_iova_link().")
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> drivers/iommu/dma-iommu.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>
> Did you find it by code inspection?
Yes, I checked how the batched CPu sync will fit there and noticed the
unlink path, see
https://lore.kernel.org/all/f8a0b873-b93c-4a91-b47d-2d11bfcf36b4@samsung.com/
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2025-11-24 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251124171014eucas1p21d3a0f2c10b43bfdb7861ee804f09951@eucas1p2.samsung.com>
2025-11-24 17:09 ` Marek Szyprowski
2025-11-24 17:15 ` Robin Murphy
2025-11-24 17:20 ` Leon Romanovsky
2025-11-24 17:40 ` Robin Murphy
2025-11-24 17:26 ` Leon Romanovsky
2025-11-25 12:20 ` Marek Szyprowski
2025-11-24 18:17 ` Jason Gunthorpe
2025-11-24 18:46 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b890945a-49af-4c45-a325-0fb106be7832@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®