From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9EB1CAA6C for ; Thu, 6 Aug 2026 18:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786041982; cv=none; b=t7KyDJPX387PLBY6+gnkFLa9eMhcIOfI++nt6t/pLkEbaIhkwewQJxrEZ/Bqv2TkJintZAn8wfHipTDa6mj3LpGcwMSTKk5epXrsF5zmLoWZ/lowtCPszk9NhysoBH9at4BBklwW/Xt4EcDP64j5hSLHQoMQyZFG6gfBeMyQ3a0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786041982; c=relaxed/simple; bh=CrJtiZSByV1ruTZyteR8UZkww5m5n05N3axrILeFLCE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uym90D4p8eufIBBoOKHoJoHgNeg69GjVTxnAxlFUNCkLUi1PA/q5RIkEuAUwlGT+4AnIpKjpWSwi42t5hM3BacV5Pz1Dj77P8aC78s0jz3t01eAX5q28VxiqtuRLzntZQGobJK4NOxSyhWmqooNK9/AO2rzot0TPsOnH0IfMJzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XARgwUnI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NhO2mBJq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XARgwUnI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NhO2mBJq" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 676IHZsD2443422 for ; Thu, 6 Aug 2026 18:46:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZGzGd7KWv89/ZWC1ybyw1tQUi56N8SEPChMtYRMb+1M=; b=XARgwUnIfulBFz4/ 3V3iaa4b8dG32wAwRvpiQxBCj0BxpbbWYGZXsyRcxQbWSMJqRBb+9EFMNAzrAfJO zoVB5JjUxcCEA7A3XbvgATuzAAiU+iX7yWb+Tvgcajgww11HAXez8x0Ht/zQ6u42 2CnA9AUJTel8JaMNEyM74s5prLDcTn2P46mlLveT3IQ10byLrE5soQddy613/0dz bpYzRpvZoOKK6DPSHUDD3gCfN55AVUW8sQgm2V57HBTsb8I7skz6fSkADq0uQ8z8 C1oMs9R+0gdpHpEWcxsEaQDJnlLuFAsZAUDhPFFPN46I1+uW+RzeV+F5ZTNfpUb9 MrgIOg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvy6hr769-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 18:46:20 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-387087245e4so585316a91.0 for ; Thu, 06 Aug 2026 11:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786041979; x=1786646779; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZGzGd7KWv89/ZWC1ybyw1tQUi56N8SEPChMtYRMb+1M=; b=NhO2mBJqiKkLMK1YbT7WwKLbYt8s+tDhhVZ2XtcuchkkK+2NeaR3p8XEG1hwQQDU8a X8sM+yYC1B5DXnAujYpMZvk+REYjbbDBz2Q2r8OvyBmualbjtbxqoyYhkLNGGss9oYg5 /j67nDc8D3WS/FaSPSGi6bIdnR3OP2UrZqmb+WlISp2AxKeX3EATdYq3u8A+YjJjYmaG AWYChvebGgDpGMO84SV4BHyUKqdFJeyUrSnWggeR2aNwU+GUaBW11bzHmBF9J/jgFKVB SsDahrdth9LDxyESS5oHv4TLNkr7PYbUOgXpWbroUjjhrI31/LC2sckzRSKnXcpmnUXX XE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786041979; x=1786646779; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZGzGd7KWv89/ZWC1ybyw1tQUi56N8SEPChMtYRMb+1M=; b=Uje+bqMa13ZvlEwr9nicrBOj+FyyxQVXYmF/WoOwNSuuofEQ4kA9dX5XPJNTreS3oL 0GefJdTITrZXj8MgDxrXATLwPX6kkPYm7B1LHyUWj3F0OheBT2pk3P1C+hfFGvtj+g1l LlV7QGXTFGykeCotXaqVvs8FyP0M/yciMi2y0uuQ/S1Fo5k3GZEHIGNIcYNrcRHkTtEB 1eMzyEOI1stHLRt8K2WzMW3kCSjJtCqUdGuyohnDXj5RtaIHP8iwFzMQz3LrT26mr2Wv G91f2vs96ZPuLyw7XL4cGtRmwqkuJRYO1fuDzgdf7W4/2PdV5N6N6MJzJ1Bn6TTYnCc5 TKHQ== X-Forwarded-Encrypted: i=1; AHgh+Ro0+Q33hL39R+GZqci6EKAWuSwYp1R17TKvDJT5ndajb12fCipp8BR4THkwphGZmj3rjxtbQcgsW+hNrOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4DZ/I/O+1MQHEBomyfSCa66fjsd39UBt97gCvKfb7cN3y+zG4 NRZhUMDBpYsnhhhzl3i6yogJTAwtyUchb5XfdvpOsnWfu/xBE0oOeyNN4fkwOV1kcWZkOAJIbOs 9OQDHMYPlHHfv39d3e/LCOXBlD8PeOukpsBnyThccuNMcKXXJaqgpyuAxOFGoj98uxR4= X-Gm-Gg: AR+sD10JNL7FYCDqRrhQ+CPuawAXVuxm08XNzrEvnCMS5dpbOhU2pVC04jf+fYVzzmm ISmkA7pTmp8yJgoBzvvUnhrCdGtOOVOapWTBJJ7V8yG+6NTsvh/dDmDjthW2pNxttrxM/kmERep 01r9/x/5llD5H/3Fh6VcPWr76PyOVCMWd7qDawMYRigqY/CskU2b9c9gyR/rUBNC38WyatD4zPA Zp5msSPIqtNsiE/d8VNhOYHaLvY7WPVxRYG+jP3uAGCOf3YV9Ogp2IQHPPdJ/Eu1M5ZriEnckCX 6deDPVhrTgRBLRrrmLx9wRHc6LD8Z9BKnw9nl7uS78eErwrE+qxWhn0fvzA9bKerb1+f/hlWmjY /ZmRlSd8UTgez0gcwxXytjUfUUB3TxdZLyDRzSQH2DldTzDnjcWRtFuokn+XVHA== X-Received: by 2002:a17:903:234c:b0:2cb:2b50:d9da with SMTP id d9443c01a7336-2d0caa0b9a1mr132823195ad.3.1786041979379; Thu, 06 Aug 2026 11:46:19 -0700 (PDT) X-Received: by 2002:a17:903:234c:b0:2cb:2b50:d9da with SMTP id d9443c01a7336-2d0caa0b9a1mr132822605ad.3.1786041978771; Thu, 06 Aug 2026 11:46:18 -0700 (PDT) Received: from [10.110.96.87] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586402e53sm44458302eec.11.2026.08.06.11.46.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 11:46:18 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 11:46:16 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7280: Add dma-coherent property into venus node To: Vishnu Reddy , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Mansur Alisha Shaik , Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260801-iris-fixes-dma-pseq-fint-v1-0-aba0cb22f6ab@oss.qualcomm.com> <20260801-iris-fixes-dma-pseq-fint-v1-2-aba0cb22f6ab@oss.qualcomm.com> Content-Language: en-US From: Deepa Guthyappa Madivalara In-Reply-To: <20260801-iris-fixes-dma-pseq-fint-v1-2-aba0cb22f6ab@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDE0NiBTYWx0ZWRfX8jk7AaXe/JuI S6JU1TKOPZ8OIHynYgLh0lqlINiQ7SKJlgSNPHMiQfS2fvCsJhz4q6N6FVxW5m3eC259jAF7iFF 4x87c4FHvqw7iFKfkvEXVIVtnpUU3Cw= X-Authority-Analysis: v=2.4 cv=PK0/P/qC c=1 sm=1 tr=0 ts=6a74d67c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=J7Er906AdXdpP4zEtWAA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDE0NiBTYWx0ZWRfXyTIvaG54fuoH yI7Z9nVLqkVCp9yoKWP+SBorOFRrNywNU62T39xw1ArcUKZOh3ZcVK1wvHeVSBC1CUYjr0HpZFI kxn5WFnMK2RpobHMgzKWc1kWFvxgtGJjeVq3Qo+pwfZXG42hnmEqHzX7leKcoLzcAlfrtDt+bHb NV76GoSqknpmMXc93pirHLAEpgT2KvbLn41AUq0UiW8IJQqgNwT+jhx+72E0j6pQ3LzUJMMEKfX Hioj1Tefx/cdoHGBaynfw03HNYZxMlmmTQm+oIUMRs1IiqeQHUWbehhqJDQ6Uxy/U97kQ9i0kTA FBIfFgAK+IwlmKQdvbkyOf+wRBxUHKbdUyqXt6pBgEwI2j3G48aLVE80KiYaLbl0UzaCFSUjIXb NKj9F816qO7tDHKKEb4OfKONCJ0qIh4XLzc9F0gjWIsI8VeWxn+1OS2xbMvuebnDgjILTapuByE mH4XQo672/Zu/N3/FGw== X-Proofpoint-GUID: KdnRFR4Cx6iMoYKn8cQBc1M6ryXl0iYB X-Proofpoint-ORIG-GUID: KdnRFR4Cx6iMoYKn8cQBc1M6ryXl0iYB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-06_02,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 impostorscore=0 spamscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060146 On 8/1/2026 12:37 AM, Vishnu Reddy wrote: > While testing with some higher resolution clips, the venus hardware > triggers a fault due to wrong input data being received. Corruption > was also observed in the captured output when the client dumped it > to a file. > > On debugging, this was traced to the venus node not declaring > dma-coherent. As a result, DMA buffers shared between the CPU and the > venus video hardware/controller are not guaranteed to be I/O coherent: > CPU writes to an input buffer can remain in CPU caches without being > visible to the video hardware when it reads the same buffer, so the > hardware receives input data that does not match what the CPU wrote. > Likewise, on the capture path, data written by the video hardware to > the output buffer may not be visible to the CPU, so the client reads > stale or partial data, resulting in corruption. > > Add the dma-coherent property to the venus node so that DMA buffers > shared between the CPU and the video hardware and controller remain > coherent. > > Fixes: 37613aee2179 ("arm64: dts: qcom: sc7280: Add venus DT node") > Cc: stable@vger.kernel.org > Signed-off-by: Vishnu Reddy > --- > arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi > index f74fa66f1a67..98184760b4bf 100644 > --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi > +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > @@ -5024,6 +5024,8 @@ venus: video-codec@aa00000 { > <&mmss_noc MASTER_VIDEO_P0 0 &mc_virt SLAVE_EBI1 0>; > interconnect-names = "cpu-cfg", "video-mem"; > > + dma-coherent; > + > iommus = <&apps_smmu 0x2180 0x20>; > memory-region = <&video_mem>; > Is this fix applicable to only Kodiak platform? > Or are there other smmu coherent platforms that might need a similar fix? >